Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules table UX enhancements for 8.7 #2998

Merged
merged 11 commits into from
Mar 9, 2023
Merged

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Feb 15, 2023

Various enhancements to the Rules page and related functionality — bundled here since they all involve the same docs pages:

Also: Confirmed that changes identified in #3005 have either been made in this PR or in other PRs.

Previews:

@github-actions
Copy link

Documentation previews:

@joepeeples

This comment was marked as resolved.

@joepeeples joepeeples changed the title Rules table persistent state Rules table UX enhancements for 8.7 Feb 15, 2023
@joepeeples joepeeples marked this pull request as ready for review February 16, 2023 20:37
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one question for Janeen that might end up in some minor text and screenshot updates. Otherwise, everything LGTM!

docs/detections/rules-ui-manage.asciidoc Show resolved Hide resolved
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM!

Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks, Joe!

@joepeeples joepeeples merged commit 48bc919 into main Mar 9, 2023
mergify bot pushed a commit that referenced this pull request Mar 9, 2023
* Add description of Clear filters option

* Update screenshots

* Mention persistent URL

* Include preset filters (not prev doc'd)

* Li'l edit

* Explain skipped rules in bulk edits

* Minor rewording for grammar

* Eh, edit again (sorry grammar)

(cherry picked from commit 48bc919)
joepeeples added a commit that referenced this pull request Mar 9, 2023
* Add description of Clear filters option

* Update screenshots

* Mention persistent URL

* Include preset filters (not prev doc'd)

* Li'l edit

* Explain skipped rules in bulk edits

* Minor rewording for grammar

* Eh, edit again (sorry grammar)

(cherry picked from commit 48bc919)

Co-authored-by: Joe Peeples <[email protected]>
@joepeeples joepeeples deleted the 2893-rules-table-persistent-state branch March 9, 2023 19:20
@joepeeples joepeeples mentioned this pull request Mar 22, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants