[DOCS] Create rule updates 8.4 #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikell821
added
Team: Detections/Response
|
Hi @jmikell821 , The preview link for above changes is not available in this PR. We have found 2 issues.
Please let us know if there is any other preview link that we need to review. Thanks!! |
jmikell821
requested review from
joepeeples,
nastasha-solomon,
benironside,
marshallmain,
e40pud and
peluja1012
benironside
reviewed
Aug 23, 2022
nastasha-solomon
approved these changes
Aug 23, 2022
joepeeples
reviewed
Aug 23, 2022
There was a problem hiding this comment.
Lots of good updates here! I added a few revision suggestions.
I also suggest cropping the inline icon image saved-query-menu.png to leave just 1 pixel padding on each side, and no border. With all the extra padding, the icon itself ends up looking very small and hard to see.
vs. 
mergify bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
* Publishing branch for a quick save. * Saving current edits. * Slight edits. * Addressing two quick bugs. * Adding feedback. (cherry picked from commit a2a21e7)
jmikell821
added a commit
that referenced
this pull request
Aug 24, 2022
* Publishing branch for a quick save. * Saving current edits. * Slight edits. * Addressing two quick bugs. * Adding feedback. (cherry picked from commit a2a21e7) Co-authored-by: Janeen Mikell-Straughn <[email protected]>
acorretti
pushed a commit
that referenced
this pull request
Nov 19, 2024
* Publishing branch for a quick save. * Saving current edits. * Slight edits. * Addressing two quick bugs. * Adding feedback. (cherry picked from commit a2a21e7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the following:
create detection Rule#2342Select the type of rule you want to createsection #2343Preview: Create a detection rule.