Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Rule execution logs tab renamed to Execution results #2329

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Aug 20, 2022

Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -45,7 +45,7 @@ Use these controls to filter what's included in the logs table:
* The *Status* drop-down filters the table by rule execution status:
** *Succeeded*: The rule was able to complete its defined search. This doesn't necessarily mean it generated an alert, just that it ran without error.
** *Failed*: The rule encountered an error that prevented it from running. For example, a machine learning rule whose corresponding machine learning job wasn't running.
** *Partial failure*: Nothing prevented the rule from running, but it still might not have returned the expected results. For example, a custom query rule tried to search an index pattern that couldn't be found in {es}.
** *Warning*: Nothing prevented the rule from running, but it still might not have returned the expected results. For example, a custom query rule tried to search an index pattern that couldn't be found in {es}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for noticing this one!

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fresh

@joepeeples joepeeples added the readyforQA PRs that are ready for QA review. label Aug 22, 2022
@ghost
Copy link

ghost commented Aug 23, 2022

Hi @joepeeples,

We have validated the Kibana documentation with reference to this PR and found that the docs are correct

image

image

Hence, we are marking this PR as QA:Approved.

Thank you!

@ghost ghost added QA:Validated Issue has been Validated by QA Team and removed readyforQA PRs that are ready for QA review. labels Aug 23, 2022
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joepeeples joepeeples merged commit 9219f99 into main Aug 23, 2022
mergify bot pushed a commit that referenced this pull request Aug 23, 2022
joepeeples added a commit that referenced this pull request Aug 23, 2022
@joepeeples joepeeples deleted the issue-2259-rule-execution-results branch August 23, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Rules QA:Validated Issue has been Validated by QA Team Team: Detections/Response Detections and Response Team: Docs v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Rule execution logs tab renamed to Execution results
5 participants