feat: Add ability to run esrallyd inside docker [ES-9146] #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favilo
changed the title
favilo
force-pushed
the
esrallyd_docker
branch
from
13c2b1d to
54c9afa
Compare
favilo
commented
Nov 5, 2024
| @@ -84,6 +84,8 @@ dependencies = [ | |||
| "zstandard==0.21.0", | |||
| # License: Python Software Foundation License | |||
| "typing-extensions==4.12.2", | |||
| # License: BSD-2-Clause license | |||
| "python-json-logger==2.0.7", | |||
There was a problem hiding this comment.
This isn't used directly, but it allows us to specify JSON logs in our logging.json configuration. Useful if you are using docker, and can't add dependencies in your virtual environment.
See change in configuration.rst for example of how to do this.
dpifke-elastic
approved these changes
Nov 11, 2024
Running the docker image with a mounted `/rally/.rally` directory that already contains the configuration file didn't work. So I had to change how we parse the logging config and rally.ini files. Now we dealy the parsing of the environment variables to read time, to make running from docker and outside of docker compatible with each other.
will allow us to actually run the thespian children inside docker.
It'll be easier to wait for the child processes from python when RALLY_RUNNING_IN_DOCKER is set. And we can just set the docker command to include `--daemon` to make sure that we don't block on the command running.
Introduce `process.current_pid()` helper function.
favilo
force-pushed
the
esrallyd_docker
branch
from
6586531 to
b6a4512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This waits for child processes to exit before exiting itself. This is necessary, because
docker -dwill just terminate the container once the main process ends.Also adding ability to log json files.