Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid logging ES credentials from running Rally processes #1863

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Avoid logging ES credentials from running Rally processes #1863

merged 5 commits into from
Jul 1, 2024

Conversation

inqueue
Copy link
Member

@inqueue inqueue commented Jun 27, 2024 •
edited
Loading

Replace the basic authentication password and API key with '*****' before creating the log entry when killing a running process.

Support both --client-options CLI formats:

  • name:value pairs
  • inline JSON

Closes #1862

@inqueue inqueue requested a review from gbanasiak June 27, 2024 20:19
@inqueue inqueue marked this pull request as ready for review June 28, 2024 17:44
@gbanasiak gbanasiak added this to the 2.11.1 milestone Jul 1, 2024
gbanasiak
gbanasiak approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@gbanasiak gbanasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. I've fixed incorrect method call after the latest refactor in d5a6508, see f6a3a89.

@gbanasiak gbanasiak added the bug Something's wrong label Jul 1, 2024
@inqueue inqueue merged commit b904c17 into elastic:master Jul 1, 2024
17 checks passed
@inqueue inqueue deleted the 20240627-password-leak branch July 1, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbanasiak gbanasiak gbanasiak approved these changes

Assignees
No one assigned
Labels
bug Something's wrong
Projects
None yet
Milestone
2.11.1
Development

Successfully merging this pull request may close these issues.

Elasticsearch cluster authentication credentials can leak into rally.log
2 participants
@inqueue @gbanasiak