Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding geoip stats telemetry #1842

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

masseyke
Copy link
Member

@masseyke masseyke commented Apr 17, 2024

This adds the ability to get information about the geoip processor's cache out of rally. The information is stored as metrics at the end of a race when this telemetry is enabled. This will be useful to better understand the distribution of IP addresses in test datasets, and how it impacts the geoip processor's runtime.

@masseyke masseyke added the :Telemetry Telemetry Devices that gather additional metrics label Apr 23, 2024
@masseyke masseyke marked this pull request as ready for review April 23, 2024 16:07
@gbanasiak gbanasiak requested review from a team and nik9000 and removed request for nik9000 April 25, 2024 09:01
Copy link
Member

@inqueue inqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@masseyke
Copy link
Member Author

LGTM, thanks!

I'm unable to merge it because of the buildkite/rally-it-serverless failure (which is an unrelated problem).

@inqueue inqueue merged commit 28b5e0f into elastic:master Apr 25, 2024
16 of 17 checks passed
@masseyke masseyke deleted the adding-geoip-stats-telemetry branch April 25, 2024 15:08
@inqueue
Copy link
Member

inqueue commented Apr 25, 2024

I'm unable to merge it because of the buildkite/rally-it-serverless failure (which is an unrelated problem).

Thank you. I bypassed branch protections and merged it on your behalf.

@gareth-ellis gareth-ellis added this to the 2.11 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Telemetry Telemetry Devices that gather additional metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants