Send version with esql #1841
Send version with esql #1841
Conversation
Elasticsearch version 8.14 will require a `version` parameter. This defaults it to the first released version. That version is supported in 8.13.3, but not before that.
|
Do we want to support versions of Elasticsearch that don't know about this parameter? Or at least wait for 8.13.3 to be released? |
I haven't checked, elastic/elasticsearch#107438 should make rally work even without this PR and this one can wait until we upgrade. As for versions of ES.... I dunno! ESQL's not GA in 8.13 so I'd be ok dropping any executions against it. But waiting to 8.13.next seems fine, especially if we have that ES PR. |
Rally uses Python client 8.6.1, so looking at this it won't? I think we need to merge this before Please also add documentation of |
++, I'd prefer we do not add more work to make pre-GA ESQL work in benchmarks. We could make the range of clients that don't need to send the version broader with the approach from elastic/elasticsearch#107438; but that'd be adding more loopholes into the API for pre-GA features. |
Added to docs, thanks for the pointer! |
|
run CI / unit macOS 3.8 (pull_request) |
|
@nik9000 We started seeing benchmark failures with ESQL operations after elastic/elasticsearch#107433 got merged, so it's time to merge this one. |
|
Merged! |
|
sorry for the delay |
This reverts commit 821f2cc.
ES|QL in 8.14 will not require a `version` parameter in requests to `_query`, after all. This removes the `version` parameter from the ES|QL runner, essentially reverting #1841.
Elasticsearch version 8.14 will require a
versionparameter. This defaults it to the first released version. That version is supported in 8.13.3, but not before that.