[it tests] Upload logs as buildkite artifact even on failure #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
favilo
commented
Mar 21, 2024
favilo
commented
- (Only for maintainers) Did you apply appropriate labels and a milestone?
favilo
commented
Mar 21, 2024
Comment on lines
+7
to
+11
| function upload_logs { | ||
| echo "--- Upload artifacts" | ||
| buildkite-agent artifact upload "${RALLY_HOME}/.rally/logs/*.log" | ||
| } | ||
|
|
There was a problem hiding this comment.
Should this go somewhere common, like .buildkite/retry.sh? It relies on $RALLY_HOME being set, so it could be fragile, is why I didn't just go ahead and do it.
There was a problem hiding this comment.
I'd say it is ok where it is. If we wanted in a seperate file, having it in something like utils.sh or upload.sh might be better, but seems a little overkill in this case. It's only a few lines
gbanasiak
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.