Skip metrics that are missing in either contender or baseline #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbanasiak
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Thank you for fixing this.
This prints twice because _metrics_table() is called twice in here.
Based on #1482 (comment) I think we should simplify and avoid a warning. WDYT?
|
Sure - i've removed the logic around the warning. I have pushed to my branch, however the PR hasnt updated yet... |
gbanasiak
approved these changes
Nov 15, 2023
|
Thank you for iterating, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1802
This fixes compare failing if a metric is missing from one of baseline or contender. It seems this functionality was partly thought about already via e.g #1482 though this adds further protection.