Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public user to serverless test #1782

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

pquentin
Copy link
Member

Rally does not currently support serverless public users, which is why we use pytest.xfail (which was simpler to use than pytest.mark.xfail due to the parametrization). Usefully, it does print the error, which is currently:

elasticsearch.NotFoundError: NotFoundError(404, 'Request for uri [/_cluster/health?wait_for_nodes=%3E%3D1] with method [GET] exists but is not available when running in serverless mode', 'Request for uri [/_cluster/health?wait_for_nodes=%3E%3D1] with method [GET] exists but is not available when running in serverless mode')

I'd suggest reviewing the two commits separately as the first reorganizes the code.

@pquentin pquentin added the :ci Everything related to CI label Sep 22, 2023
@pquentin pquentin added this to the 2.10.0 milestone Sep 22, 2023
@pquentin pquentin self-assigned this Sep 22, 2023
@pquentin pquentin changed the title It serverless public user Add public user to serverless test Sep 22, 2023
Copy link
Contributor

@gbanasiak gbanasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@pquentin pquentin merged commit e24970a into elastic:master Sep 25, 2023
11 checks passed
@pquentin pquentin deleted the it-serverless-public-user branch September 25, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ci Everything related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants