Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Rally with operator on Serverless during CI #1775

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Test Rally with operator on Serverless during CI #1775

merged 4 commits into from
Sep 7, 2023

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Sep 7, 2023

No description provided.

@pquentin pquentin added the :ci Everything related to CI label Sep 7, 2023
@pquentin pquentin self-assigned this Sep 7, 2023
gareth-ellis
gareth-ellis approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@gareth-ellis gareth-ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

gbanasiak
gbanasiak reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@gbanasiak gbanasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Should there also be a test with Python 3.8 by analogy to non-serverless pipeline? Please also check small remarks inline.

it_serverless/serverless_test.py Outdated Show resolved Hide resolved
it_serverless/serverless_test.py Outdated Show resolved Hide resolved
@pquentin
Copy link
Member Author

pquentin commented Sep 7, 2023

Thank you. Should there also be a test with Python 3.8 by analogy to non-serverless pipeline?

I would rather not do this, because this is specifically about testing serverless, and it costs resources (we spin up a project on Elastic Cloud). This is also in line with the idea that Rally should eventually support a single Python version.

@gbanasiak gbanasiak self-requested a review September 7, 2023 15:58
gbanasiak
gbanasiak approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@gbanasiak gbanasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM.

@pquentin pquentin merged commit dac0a8c into master Sep 7, 2023
22 checks passed
@pquentin pquentin modified the milestones: 2.10.0, 2.9.1 Sep 14, 2023
@gbanasiak gbanasiak deleted the rally-it-serverless-pipeline branch November 5, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gareth-ellis gareth-ellis gareth-ellis approved these changes

@gbanasiak gbanasiak gbanasiak approved these changes

Assignees

@pquentin pquentin

Labels
:ci Everything related to CI
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@pquentin @gbanasiak @gareth-ellis