Finish migration to native pytest #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
added
cleanup
DJRickyB
approved these changes
Feb 22, 2022
|
|
||
| self.assertAlmostEqual(50, self.metrics_store.get_mean("query_latency")) | ||
| assert round(abs(50 - self.metrics_store.get_mean("query_latency")), 7) == 0 |
There was a problem hiding this comment.
seems fine, but for my programming knowledge is there a reason for 7 here?
There was a problem hiding this comment.
This is just assertAlmostEqual default behavior. I should switch those assert round(abs(...)) and assert math.isclose(...) to use pytest.approx() in a follow up PR.
|
Thank you for the kind words! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last PR after #1387, #142, #1426 and #1439. When this and #1439 have been merged, then we won't be using TestCase anymore, which means the test will be much more readable.