-
Notifications
You must be signed in to change notification settings - Fork 313
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes #1595: Add method to process.py to return both return code and …
…logs (#1828) * Change run_subprocess to return `CompletedProcess` object As requested in #1595 * Avoid the double call to `run_subprocess*` in `is_branch()` * Adding returncode, stdout fields to `run_subprocess_with_logging` * Change `with ... Popen()` to `run()` instead. This will be more compatible with the changes, and keep the return type the same as `run_subprocess()` - universal_newline was changed to text in recent versions of the library * Revert all changes, except typing. Will be adding new function * Add `run_subprocess_with_logging_and_output` verbose method. * Taking care of some final nits.
- Loading branch information
Showing
4 changed files
with
89 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters