Enable logsdb for http_logs #646
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "operation": { | ||
| "name": "delete-data-stream", | ||
| "operation-type": "delete-data-stream", | ||
| "only-if-exists": false, | ||
| "data-stream": ["logs-181998", "logs-191998", "logs-201998", "logs-211998", "logs-221998", "logs-231998", "logs-241998", "reindexed-logs"] | ||
| }, | ||
| "tags": ["setup"] | ||
| }, | ||
| { | ||
| "operation": { | ||
| "name": "delete-index", | ||
| "operation-type": "delete-index", | ||
| "only-if-exists": false, | ||
| "index": ["logs-181998", "logs-191998", "logs-201998", "logs-211998", "logs-221998", "logs-231998", "logs-241998", "reindexed-logs"] | ||
| }, | ||
| "tags": ["setup"] | ||
| }, | ||
| { | ||
| "operation" : { | ||
| "name": "delete-all-index-templates", | ||
| "operation-type": "delete-composable-template" | ||
| }, | ||
| "tags": ["setup"] | ||
| }, | ||
| { | ||
| "operation": { | ||
| "name": "create-all-templates", | ||
| "operation-type": "create-composable-template" | ||
| }, | ||
| "tags": ["setup"] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,84 @@ | ||
| { | ||
| "priority": 101, | ||
|
There was a problem hiding this comment. According to https://www.elastic.co/guide/en/elasticsearch/reference/current/index-templates.html There was a problem hiding this comment. I used 101 to ensure the template took priority over the built-in one for There was a problem hiding this comment. I was referring to the fact that the standard ones should have 100...so it should be fine for this to have 101 (and have higher priority). I saw some CI failures saying that there is a template priority issue while merging templates. There was a problem hiding this comment. I see |
||
| "index_patterns": ["logs-*", "reindexed-logs"], | ||
| {%- if index_mode == "logsdb" or index_type == "data_stream" %} | ||
| "data_stream": {}, | ||
| {%- endif %} | ||
| "template": { | ||
| "settings": { | ||
| {%- if index_mode %} | ||
| "mode": {{ index_mode | tojson }}, | ||
| {%- endif -%} | ||
| {# non-serverless-index-settings-marker-start -#} | ||
| {%- if build_flavor != "serverless" %} | ||
| "index.number_of_replicas": {{ number_of_replicas | default(0) | tojson }}, | ||
| {%- endif -%} | ||
| {%- if build_flavor != "serverless" or serverless_operator == true %} | ||
| "index.number_of_shards": {{ number_of_shards | default(5) | tojson }}, | ||
| "index.requests.cache.enable": false | ||
| {%- endif -%} | ||
| {# non-serverless-index-settings-marker-end #} | ||
| }, | ||
| "mappings": { | ||
| "dynamic": "strict", | ||
| {%- if index_mode != "logsdb" %} | ||
| "_source": { | ||
| "enabled": {{ source_enabled | default(true) | tojson }} | ||
| }, | ||
| {%- endif %} | ||
| "properties": { | ||
| "@timestamp": { | ||
| {%- if (ingest_pipeline is defined and ingest_pipeline == "grok") or runtime_fields is defined %} | ||
| "format": "strict_date_optional_time", | ||
| {%- else %} | ||
| "format": "epoch_second", | ||
| {%- endif %} | ||
| "type": "date" | ||
| }, | ||
| {%- if runtime_fields is defined %} | ||
| "message": { | ||
| "type": "wildcard", | ||
| "fields": { | ||
| "keyword": { | ||
| "type": "keyword" | ||
| } | ||
| } | ||
| }, | ||
| {%- else %} | ||
| "message": { | ||
| "type": "keyword", | ||
| "index": false, | ||
| "doc_values": false | ||
| }, | ||
| {%- endif %} | ||
| "clientip": { | ||
| "type": "ip" | ||
| }, | ||
| "request": { | ||
| "type": "match_only_text", | ||
| "fields": { | ||
| "raw": { | ||
| "ignore_above": 256, | ||
| "type": "keyword" | ||
| } | ||
| } | ||
| }, | ||
| "status": { | ||
| "type": "integer" | ||
| }, | ||
| "size": { | ||
| "type": "integer" | ||
| }, | ||
| "geoip" : { | ||
| "properties" : { | ||
| "country_name": { "type": "keyword" }, | ||
| "city_name": { "type": "keyword" }, | ||
| "location" : { "type" : "geo_point" } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| {%- if runtime_fields is defined %}, | ||
| "runtime": { | ||
| {%- set sources = [('source', 'message.source'), ('wildcard', 'message'), ('keyword', 'message.keyword')] %} | ||
| {%- for source_type, field in sources %} | ||
|
|
@@ -97,6 +151,6 @@ | |
| "type": "keyword", | ||
| "script": "emit(params._source.message)" | ||
| } | ||
| }{% endif %} | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively we could just enable logsdb on the plain index and not use data streams. This would make this change a little bit simpler, since this is an index oriented track?
But I think it is fine to use logsdb with data stream here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL logsdb can be enabled on a plain index. I took from https://www.elastic.co/guide/en/elasticsearch/reference/current/logs-data-stream.html it was required to be a data stream.
I would like to leave data stream support for serverless, though I think combining the template into one may have complicated things a bit, so I am thinking of splitting the template into two files: one for a plain index, the other for data stream. WDYT?