Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use documented track param parallel_indexing_target_throughput #617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wangch079
Copy link
Member

The Wikipedia track documented that it supported track param parallel_indexing_target_throughput but it doesn't.

This PR updates the track to use the param parallel_indexing_target_throughput

@wangch079 wangch079 requested a review from jimczi June 5, 2024 13:04
Copy link
Member

@gareth-ellis gareth-ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this is following the default value in the README, however you should be aware that this will possibly change the results of the benchmark. The number for target throughput is a total requests per second, across all clients, not a percentage. You could add some logic that checks if the parameter has been set, and if so include target-throughput, otherwise exclude it

@wangch079
Copy link
Member Author

The number for target throughput is a total requests per second, across all clients, not a percentage.

This is my understanding as well. If we use the default value for parallel_indexing_search_clients (20), and parallel_indexing_target_throughput (100), each client will try to send 5 requests per second.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants