Skip to content

Commit

Permalink
Include a variable to control synthetic_source_keep parameter (#682)
Browse files Browse the repository at this point in the history
This PR introduces a new track parameter, `synthetic_source_keep` which is used to control the
behaviour of synthetic source for all field types. It can have values `none`, `arrays` or `all` (`all`
not usable when set at index level).
See elastic/elasticsearch#112706 to understand the effect of each value.

Later on we will use this to change the behaviour in our nightlies and run benchmarks on both `elastic/logs`
and `elastic/security` using value `arrays`.
  • Loading branch information
salvatore-campagna authored Sep 30, 2024
1 parent d991a14 commit 0a09c6a
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 1 deletion.
1 change: 1 addition & 0 deletions elastic/logs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ The following parameters are available:
* `corpora_uri_base` (default: `https://rally-tracks.elastic.co`) - Specify the base location of the datasets used by this track.
* `lifecycle` (default: unset to fall back on Serverless detection) - Specifies the lifecycle management feature to use for data streams. Use `ilm` for index lifecycle management or `dlm` for data lifecycle management. By default, `dlm` will be used for benchmarking Serverless Elasticsearch.
* `workflow-request-cache` (default: `true`) - Explicit control of request cache query parameter in searches executed in a workflow. This can be further overriden at an operation level with `request-cache` parameter.
* `synthetic_source_keep` (default: unset) - Allows overriding the default synthetic source behaviour for all field types with the following values: `none` (equivalent to unset) - no source is stored, `arrays` - source stored as is only for multi-value (array) fields.

### Data Download Parameters

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@
{% if index_mode %}
"index": {
"mode": {{ index_mode | tojson }},
{% if synthetic_source_keep and synthetic_source_keep != 'none' %}
"mapping": {
"synthetic_source_keep": "arrays"
"synthetic_source_keep": "{{ synthetic_source_keep }}"
}
{% endif %}
}
{% endif %}
}
Expand Down
1 change: 1 addition & 0 deletions elastic/security/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ The following parameters are available:
* `wait_for_status` (default: `green`) - The track creates Data Streams prior to indexing. All created Data Streams must at least reach this status before indexing commences. Reduce to `yellow` for clusters where green isn't possible e.g. single node.
* `corpora_uri_base` (default: `https://rally-tracks.elastic.co`) - Specify the base location of the datasets used by this track.
* `index_mode` (default: unset) - A parameter meant to be used internally which defines one of the available indexing modes, "standard", "logsdb" or "time_series". If not set, "standard" is used.
* `synthetic_source_keep` (default: unset) - Allows overriding the default synthetic source behaviour for all field types with the following values: `none` (equivalent to unset) - no source is stored, `arrays` - source stored as is only for multi-value (array) fields.

### Data Generation Parameters

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
{% if index_mode %}
"index": {
"mode": {{ index_mode | tojson }},
{% if synthetic_source_keep and synthetic_source_keep != 'none' %}
"mapping": {
"synthetic_source_keep": "{{ synthetic_source_keep }}"
},
{% endif %}
"sort.field": [ "host.hostname", "@timestamp" ],
"sort.order": [ "asc", "desc" ],
"sort.missing": ["_first", "_last"]
Expand Down

0 comments on commit 0a09c6a

Please sign in to comment.