Add ebpf lost event counter. Issue #38 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return (-1); | ||
|
|
||
| for (i = 0; i < libbpf_num_possible_cpus(); i++) | ||
| qq->stats.lost = pcpu_ees[i].lost; |
There was a problem hiding this comment.
don't care about the sent?
There was a problem hiding this comment.
At the moment no, I don't have the statistics for sent yet, I just wanted to get it on the same stage as the kprobes for now.
nicholasberlin
approved these changes
Jul 2, 2024
mjwolf
approved these changes
Jul 2, 2024
Pretty straighforward, contrary to kprobes which we get the counter on the data path, with ebpf we have to actually read it, so add a new ops for updating the counter, we should caution users to not hammer the reading, as it's real syscall. Tested by hacking quark-mon away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes the pending PR: elastic/ebpf#198 Once that is merged I'll rebase this, so ignore the elastic-ebpf/* bits.
Pretty straighforward, contrary to kprobes which we get the counter on the data path, with ebpf we have to actually read it, so add a new ops for updating the counter, we should caution users to not hammer the reading, as it's real syscall.
Tested by hacking quark-mon away.