Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alerting terminology #679

Merged
merged 2 commits into from
May 20, 2021
Merged

Conversation

EamonnTP
Copy link
Contributor

Summary

This PR updates the terminology used for alerting. An alert is the actual instance of the alert and a rule is the set of conditions that are checked periodically to trigger the alert.

Still to do: update the APM app docs.

Docs preview

Related issue

#443

@EamonnTP EamonnTP added docs Improvements or additions to documentation v7.13.0 labels May 19, 2021
@EamonnTP EamonnTP requested a review from a team May 19, 2021 14:40
@EamonnTP EamonnTP self-assigned this May 19, 2021
@apmmachine
Copy link
Contributor

apmmachine commented May 19, 2021

A documentation preview will be available soon:

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments. Otherwise looks great!

When group by fields are selected, but no documents are containing the selected field(s) within the given time range (of alert execution), then we can't determine the group(s). This is relevant when the alert condition is sensitive to a certain number of documents, and that number might be 0. To use an example, if we want to know that Host A has less than five documents matching a condition, but the host has stopped reporting logs for the entire duration we were querying, no alert is triggered.
When group by fields are selected, but no documents contain the selected field(s) within the given time range of when the alert is triggered,
then you can't determine the group(s). This is relevant when the rule condition is sensitive to a certain number of documents, and
that number might be `0`. For example, if you want to know that `Host A` has less than five documents matching a condition,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a little trouble parsing the sentence that begins "For example, if you want ..." Maybe rephrase. Also, should. it say we or you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dedemorton After reading it again, yeah, it's hard to parse. Maybe this is clearer?

For example, an alert is not triggered if a host has stopped reporting logs for the duration of the query.


- `context.group`: This variable resolves to the **group** that the rule conditions detected.
For Inventory rules, this is the name of a monitored host, pod, container, etc. For metric threshold rules,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For Inventory rules, this is the name of a monitored host, pod, container, etc. For metric threshold rules,
For Inventory rules, this is the name of a monitored host, pod, container, and so on. For metric threshold rules,

@bmorelli25
Copy link
Member

Question: does it make sense to update all of these if some didn't make it into 7.13? I don't know 🤷 . I ask because I'm running BC8 and it looks like only some apps have updated to the new terminology.
Screen Shot 2021-05-19 at 2 25 16 PM


For example, Uptime hasn't:

Screen Shot 2021-05-19 at 2 24 52 PM


But Metrics has:

Screen Shot 2021-05-19 at 2 30 33 PM


Even weirder, you select "Create Alert" in a dropdown, only to be taken to a page that says "Create Rule"

Screen Shot 2021-05-19 at 2 32 45 PM


Screen Shot 2021-05-19 at 2 32 59 PM

@EamonnTP
Copy link
Contributor Author

@bmorelli25 Yeah the terminology does seem a little disjointed, especially for the Settings pages. For the Uptime settings page, I have kept it generic; configure connectors. My understanding is that Create alert is correct and consistent across the apps, as you are creating an instance of the alert. The Create rule dialog relates to creating a set of conditions that trigger that alert instance. In the Stack Managment app, you still have the heading Alerts and Insights, with a list of the rules you created.

@bmorelli25
Copy link
Member

👍 Got it, thanks!

@@ -32,34 +32,34 @@ data outside of this pattern.
image::images/heartbeat-indices.png[Heartbeat indices]

[[configure-uptime-alert-connectors]]
== Configure alert connectors
== Configure connectors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think this works well until Uptime migrates away from the deprecated alerting API. There's an issue in Kibana somewhere...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting me know.

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EamonnTP EamonnTP merged commit 134a65b into elastic:master May 20, 2021
@EamonnTP EamonnTP deleted the update-alerting-terms branch May 20, 2021 16:04
EamonnTP pushed a commit to EamonnTP/observability-docs that referenced this pull request May 20, 2021
* Update alerting terminology

* Review edits
EamonnTP pushed a commit to EamonnTP/observability-docs that referenced this pull request May 20, 2021
* Update alerting terminology

* Review edits
EamonnTP pushed a commit that referenced this pull request May 20, 2021
* Update alerting terminology

* Review edits
EamonnTP pushed a commit that referenced this pull request May 20, 2021
* Update alerting terminology

* Review edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants