-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update alerting terminology #679
Conversation
A documentation preview will be available soon: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments. Otherwise looks great!
When group by fields are selected, but no documents are containing the selected field(s) within the given time range (of alert execution), then we can't determine the group(s). This is relevant when the alert condition is sensitive to a certain number of documents, and that number might be 0. To use an example, if we want to know that Host A has less than five documents matching a condition, but the host has stopped reporting logs for the entire duration we were querying, no alert is triggered. | ||
When group by fields are selected, but no documents contain the selected field(s) within the given time range of when the alert is triggered, | ||
then you can't determine the group(s). This is relevant when the rule condition is sensitive to a certain number of documents, and | ||
that number might be `0`. For example, if you want to know that `Host A` has less than five documents matching a condition, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a little trouble parsing the sentence that begins "For example, if you want ..." Maybe rephrase. Also, should. it say we or you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton After reading it again, yeah, it's hard to parse. Maybe this is clearer?
For example, an alert is not triggered if a host has stopped reporting logs for the duration of the query.
|
||
- `context.group`: This variable resolves to the **group** that the rule conditions detected. | ||
For Inventory rules, this is the name of a monitored host, pod, container, etc. For metric threshold rules, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Inventory rules, this is the name of a monitored host, pod, container, etc. For metric threshold rules, | |
For Inventory rules, this is the name of a monitored host, pod, container, and so on. For metric threshold rules, |
@bmorelli25 Yeah the terminology does seem a little disjointed, especially for the Settings pages. For the Uptime settings page, I have kept it generic; |
👍 Got it, thanks! |
@@ -32,34 +32,34 @@ data outside of this pattern. | |||
image::images/heartbeat-indices.png[Heartbeat indices] | |||
|
|||
[[configure-uptime-alert-connectors]] | |||
== Configure alert connectors | |||
== Configure connectors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I think this works well until Uptime migrates away from the deprecated alerting API. There's an issue in Kibana somewhere...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for letting me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Update alerting terminology * Review edits
* Update alerting terminology * Review edits
Summary
This PR updates the terminology used for alerting. An alert is the actual instance of the alert and a rule is the set of conditions that are checked periodically to trigger the alert.
Still to do: update the APM app docs.
Docs preview
Related issue
#443