Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reword ILM how to guide for revert to ILM policies #4667

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Reword ILM how to guide for revert to ILM policies #4667

merged 7 commits into from
Dec 12, 2024

Conversation

lahsivjar
Copy link
Contributor

Description

Rewords the ILM how-to guide for APM to mention revert to ILM policies (from DSL introduced in 8.15).
CC: @elastic/obs-ds-intake-services (not able to add as reviewers)

Documentation sets edited in this PR

Related issue

Closes elastic/apm-server#14708

Checklist

  • Product/Engineering Review
  • Writer Review

@lahsivjar lahsivjar requested a review from simitt December 11, 2024 17:13
@lahsivjar lahsivjar requested a review from a team as a code owner December 11, 2024 17:13
@github-actions GitHub Actions
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

This pull request does not have a backport label. Could you fix it @lahsivjar? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 11, 2024
1pkg
1pkg previously approved these changes Dec 11, 2024
View reviewed changes
simitt
simitt previously approved these changes Dec 11, 2024
View reviewed changes
@lahsivjar lahsivjar added the backport-8.17 Automated backport with mergify label Dec 11, 2024
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Dec 11, 2024
colleenmcginnis
colleenmcginnis reviewed Dec 11, 2024
View reviewed changes
docs/en/observability/apm/manage-storage/ilm-how-to.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/apm/manage-storage/ilm-how-to.asciidoc Outdated
For _new_ clusters created in 8.15 or later, if you prefer to continue using ILM,
follow the steps in this guide to create a custom ILM policy and add it to the `*@custom` component template for each data stream.
Some older indices might be managed by {ref}/data-stream-lifecycle.html[data stream lifecycle (DSL)] if cluster is upgraded to 8.17.
More details are available in <<apm-release-notes>>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there going to be more details in the 8.17 release notes? It would be nice to link to something more specific than the general release notes page. I'm kind of surprised there's no release notes page for 8.17 on the main / master branch. 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1pkg can you ensure the release notes are on main, 8.x and 8.17 branch please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colleenmcginnis Given that we will have the release notes soonish, should we go ahead with merging this first?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simitt here's the PR https://github.com/elastic/apm-server/pull/14929/files where I manually copied 8.17 changelog to the main branch. I'm not sure why, but the current minor release automation only creates changelog for specific 8.x and 8.17+ branches.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR with the changelog from above was merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @1pkg! @lahsivjar I think we should update the release note link to the 8.17 page so it's easier for users to find the relevant information. What do you think?

Suggested change
More details are available in <<apm-release-notes>>.
More details are available in <<apm-release-notes-8.17>>.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need this PR, too: elastic/apm-server#14932.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @colleenmcginnis for raising this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lahsivjar I'll rebuild this PR after elastic/apm-server#14932 is merged and set this PR to automerge. 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@colleenmcginnis colleenmcginnis mentioned this pull request Dec 12, 2024
Merged
4 tasks
@colleenmcginnis colleenmcginnis enabled auto-merge (squash) December 12, 2024 17:46
@colleenmcginnis colleenmcginnis merged commit e7f4f98 into elastic:main Dec 12, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
@lahsivjar @mergify
Reword ILM how to guide for revert to ILM policies (#4667)
adc695c 
* Reword ILM how to guide for revert to ILM policies

* Fix typo

* Remove notes entirely

* Add important section

* Reword to be more brief

* Update docs/en/observability/apm/manage-storage/ilm-how-to.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

* Update docs/en/observability/apm/manage-storage/ilm-how-to.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

---------

Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit e7f4f98)
@mergify mergify bot mentioned this pull request Dec 12, 2024
Merged
2 tasks
@colleenmcginnis colleenmcginnis added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 12, 2024
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
@lahsivjar @mergify
Reword ILM how to guide for revert to ILM policies (#4667)
69d45c1 
* Reword ILM how to guide for revert to ILM policies

* Fix typo

* Remove notes entirely

* Add important section

* Reword to be more brief

* Update docs/en/observability/apm/manage-storage/ilm-how-to.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

* Update docs/en/observability/apm/manage-storage/ilm-how-to.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

---------

Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit e7f4f98)
@mergify mergify bot mentioned this pull request Dec 12, 2024
Merged
2 tasks
colleenmcginnis pushed a commit that referenced this pull request Dec 12, 2024
@mergify @lahsivjar
Reword ILM how to guide for revert to ILM policies (#4667) (#4680)
bb437c8 
* Reword ILM how to guide for revert to ILM policies

* Fix typo

* Remove notes entirely

* Add important section

* Reword to be more brief

* Update docs/en/observability/apm/manage-storage/ilm-how-to.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

* Update docs/en/observability/apm/manage-storage/ilm-how-to.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

---------

Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit e7f4f98)

Co-authored-by: Vishal Raj <[email protected]>
colleenmcginnis pushed a commit that referenced this pull request Dec 12, 2024
@mergify @lahsivjar
Reword ILM how to guide for revert to ILM policies (#4667) (#4681)
929d8ac 
* Reword ILM how to guide for revert to ILM policies

* Fix typo

* Remove notes entirely

* Add important section

* Reword to be more brief

* Update docs/en/observability/apm/manage-storage/ilm-how-to.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

* Update docs/en/observability/apm/manage-storage/ilm-how-to.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

---------

Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit e7f4f98)

Co-authored-by: Vishal Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1pkg 1pkg 1pkg left review comments

@simitt simitt simitt left review comments

@colleenmcginnis colleenmcginnis colleenmcginnis approved these changes

Assignees
No one assigned
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify needs-writer-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs][8.17.0] Reverting back to ILM as default
4 participants
@lahsivjar @simitt @colleenmcginnis @1pkg