-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quickstarts for 8.16 #4582
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
@dedemorton @eedugon |
I like the screenshots for this type of docs, at least to get an overview of what you are going to see when you follow the doc, even if it could get a bit outdated at some point. But whatever you prefer, I completely understand the negative aspects of using screenshots, and as @alaudazzi says, the In anyway I would suggest to double check with PMs before removing the screenshots. If everybody agrees I'm totally ok with removing them too. If the conversation is around the format of the screenshots of the In the second case I'd try at least to ensure the image doesn't ends up being too big on the final doc. |
Thanks for you input. Since we're split in the middle, for the review, I think I will include the screenshot (using the version that provides context) and ask PMs to make a case for keeping it. If the onboarding experience is more stable because most of the quickstarts are GA, then maybe it won't change as much going forward. |
115ece3
to
01685c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc covering the quickstart onboarding workflow for Firehose in serverless does not mention that this functionality is currently in Tech Preview.
Good catch! The preview tag must have gotten removed when we did a general cleanup of preview tags for GA. (In some cases, the tag was doing double duty.) |
f990f4c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦭 👍
* Update quickstarts for 8.16 * Add preview tag to aws firehose quickstart (cherry picked from commit 9afec56) # Conflicts: # docs/en/serverless/images/quickstart-autodetection-command.png # docs/en/serverless/images/quickstart-aws-firehose-entry-point.png # docs/en/serverless/images/quickstart-k8s-entry-point.png # docs/en/serverless/quickstarts/collect-data-with-aws-firehose.asciidoc # docs/en/serverless/quickstarts/k8s-logs-metrics.asciidoc # docs/en/serverless/quickstarts/monitor-hosts-with-elastic-agent.asciidoc
* Update quickstarts for 8.16 * Add preview tag to aws firehose quickstart (cherry picked from commit 9afec56) # Conflicts: # docs/en/serverless/images/quickstart-autodetection-command.png # docs/en/serverless/images/quickstart-aws-firehose-entry-point.png # docs/en/serverless/images/quickstart-k8s-entry-point.png # docs/en/serverless/quickstarts/collect-data-with-aws-firehose.asciidoc # docs/en/serverless/quickstarts/k8s-logs-metrics.asciidoc # docs/en/serverless/quickstarts/monitor-hosts-with-elastic-agent.asciidoc
* Update quickstarts for 8.16 * Add preview tag to aws firehose quickstart (cherry picked from commit 9afec56) # Conflicts: # docs/en/serverless/images/quickstart-autodetection-command.png # docs/en/serverless/images/quickstart-aws-firehose-entry-point.png # docs/en/serverless/images/quickstart-k8s-entry-point.png # docs/en/serverless/quickstarts/collect-data-with-aws-firehose.asciidoc # docs/en/serverless/quickstarts/k8s-logs-metrics.asciidoc # docs/en/serverless/quickstarts/monitor-hosts-with-elastic-agent.asciidoc
* Update quickstarts for 8.16 (#4582) * Update quickstarts for 8.16 * Add preview tag to aws firehose quickstart (cherry picked from commit 9afec56) * Delete docs/en/serverless directory --------- Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update quickstarts for 8.16 (#4582) * Update quickstarts for 8.16 * Add preview tag to aws firehose quickstart (cherry picked from commit 9afec56) * Delete docs/en/serverless directory --------- Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update quickstarts for 8.16 (#4582) * Update quickstarts for 8.16 * Add preview tag to aws firehose quickstart (cherry picked from commit 9afec56) * Delete docs/en/serverless directory --------- Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Updates the Observability quickstarts for version 8.16.0:
Preview links
Please remember to also review the changed lines shown in the Files changed tab.
Stateful:
Serverless:
Documentation sets edited in this PR
Check all that apply.
docs/en/observability/*
)docs/en/serverless/*
)docs/en/integrations/*
)Related issue
Closes #4534, #4562, and #4563
Checklist
Follow-up tasks
Select one.