Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update APM Server throughput number for 8.16.0 #4441

Merged
merged 8 commits into from
Jan 8, 2025

Conversation

rubvs
Copy link
Contributor

@rubvs rubvs commented Oct 28, 2024

Description

The removal of Memory Pooling and the addition of PGO in 8.16.0 introduced some changes that will influence throughput. This PR updates the throughput numbers for APM Server for 8.16.0.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes elastic/apm-server#13871 (comment)

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Oct 28, 2024

This pull request does not have a backport label. Could you fix it @rubvs? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 28, 2024
@bmorelli25 bmorelli25 added backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Oct 30, 2024
@bmorelli25
Copy link
Member

Thanks, @rubvs. When you're ready, @colleenmcginnis will review and get this merged for you.

@rubvs
Copy link
Contributor Author

rubvs commented Oct 31, 2024

Thanks, @rubvs. When you're ready, @colleenmcginnis will review and get this merged for you.

@bmorelli25 @colleenmcginnis thanks for the follow up. We are still waiting for results for AWS and Azure then I'll move it out of Draft Status

@rubvs rubvs changed the title update GCP throughput number for 8.16.0 Update APM Server throughput number for 8.16.0 Oct 31, 2024
@colleenmcginnis colleenmcginnis added the backport-8.17 Automated backport with mergify label Nov 22, 2024
@rubvs rubvs requested a review from simitt December 13, 2024 14:13
@rubvs rubvs marked this pull request as ready for review December 13, 2024 14:13
@rubvs rubvs requested a review from a team as a code owner December 13, 2024 14:13
@rubvs rubvs force-pushed the update-throughput-numbers-8.16.0 branch from c6c8dad to 3c9378b Compare December 13, 2024 17:32
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions below.

@rubvs
Copy link
Contributor Author

rubvs commented Jan 7, 2025

Thank you @colleenmcginnis! I am just waiting for final approval from @simitt before we merge.

Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. The only minor nit that I have is to please round the numbers to the nearest 1,000 as it was done with the old numbers. This is supposed to provide rough guidance, which we support with rounded numbers, rather than very specific ones.

simitt
simitt previously approved these changes Jan 7, 2025
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge if the build passes!

@rubvs rubvs merged commit dcc4d68 into elastic:main Jan 8, 2025
4 checks passed
@rubvs rubvs deleted the update-throughput-numbers-8.16.0 branch January 8, 2025 02:08
mergify bot pushed a commit that referenced this pull request Jan 8, 2025
mergify bot pushed a commit that referenced this pull request Jan 8, 2025
mergify bot pushed a commit that referenced this pull request Jan 8, 2025
colleenmcginnis pushed a commit that referenced this pull request Jan 8, 2025
(cherry picked from commit dcc4d68)

Co-authored-by: Ruben van Staden <[email protected]>
colleenmcginnis pushed a commit that referenced this pull request Jan 8, 2025
(cherry picked from commit dcc4d68)

Co-authored-by: Ruben van Staden <[email protected]>
colleenmcginnis pushed a commit that referenced this pull request Jan 8, 2025
(cherry picked from commit dcc4d68)

Co-authored-by: Ruben van Staden <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeat benchmarks to update the Performance guide for 8.16
4 participants