Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability Onboarding] Add AWS Firehose quickstart #4433

Merged
merged 11 commits into from
Nov 12, 2024

Conversation

alaudazzi
Copy link
Contributor

@alaudazzi alaudazzi commented Oct 25, 2024

Description

This PR adds a new quickstart for AWS Firehose.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes elastic/kibana#191835

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:

@alaudazzi alaudazzi added needs-product-review backport-8.16 Automated backport with mergify labels Oct 25, 2024
@alaudazzi alaudazzi self-assigned this Oct 25, 2024
@alaudazzi alaudazzi requested a review from a team as a code owner October 25, 2024 13:23
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link

@mykolaharmash mykolaharmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I added just a few minor comments.

@dedemorton dedemorton added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 29, 2024
@bmorelli25
Copy link
Member

run docs-build

@bmorelli25
Copy link
Member

Thanks, @alaudazzi! LGTM pending these last two changes from Mykola.

@alaudazzi
Copy link
Contributor Author

@mykolaharmash
I integrated your feedback. Can you have a final look?

mykolaharmash
mykolaharmash previously approved these changes Nov 6, 2024
Copy link

@mykolaharmash mykolaharmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alaudazzi! To me this looks great ✨

bmorelli25
bmorelli25 previously approved these changes Nov 6, 2024
@alaudazzi alaudazzi dismissed stale reviews from bmorelli25 and mykolaharmash via 1415137 November 8, 2024 10:17
@alaudazzi
Copy link
Contributor Author

alaudazzi commented Nov 8, 2024

@mykolaharmash @kaiyan-sheng
I added the list of (required and optional) parameters.
Here is a doc preview. Can you check if this looks good to you?

@alaudazzi
Copy link
Contributor Author

From a Slack thread with @mykolaharmash:
"there are two more requests from Akhilesh:

  • To add another point to the Limitations section saying that cloudformation template detects and ingests logs/metrics only in a single AWS region
  • To add a table that shows whether logs and/or metrics are ingested for every supported AWS service based on this table. It's not about listing the available dashboards but only calling out which data type is supported ("Data Type" column in the spreadsheet) "

@alaudazzi
Copy link
Contributor Author

@akhileshpok @mykolaharmash
Here is the doc preview with the latest updates. Please let me know if this is OK with you.

@akhileshpok
Copy link

@alaudazzi - Thanks. It looks good to me! cc-@mykolaharmash

@alaudazzi alaudazzi merged commit 04b8cef into elastic:main Nov 12, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
* Add AWS Firehose quickstart

* More edits

* Add link to AWS integration docs

* Integrate reviewers feedback

* Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Integrate Mykola's feedback

* Add list of parameters

* Integrate reviewer feedback

* Add table

---------

Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit 04b8cef)
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
* Add AWS Firehose quickstart

* More edits

* Add link to AWS integration docs

* Integrate reviewers feedback

* Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Integrate Mykola's feedback

* Add list of parameters

* Integrate reviewer feedback

* Add table

---------

Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit 04b8cef)
Copy link

@akhileshpok akhileshpok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc looks good to me.

alaudazzi added a commit that referenced this pull request Nov 12, 2024
* Add AWS Firehose quickstart

* More edits

* Add link to AWS integration docs

* Integrate reviewers feedback

* Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Integrate Mykola's feedback

* Add list of parameters

* Integrate reviewer feedback

* Add table

---------

Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit 04b8cef)

Co-authored-by: Arianna Laudazzi <[email protected]>
alaudazzi added a commit that referenced this pull request Nov 12, 2024
* Add AWS Firehose quickstart

* More edits

* Add link to AWS integration docs

* Integrate reviewers feedback

* Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Integrate Mykola's feedback

* Add list of parameters

* Integrate reviewer feedback

* Add table

---------

Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit 04b8cef)

Co-authored-by: Arianna Laudazzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Onboarding] Docs for AWS Firehose
6 participants