-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability Onboarding] Add AWS Firehose quickstart #4433
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I added just a few minor comments.
docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc
Show resolved
Hide resolved
docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc
Show resolved
Hide resolved
docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc
Show resolved
Hide resolved
…se.asciidoc Co-authored-by: Brandon Morelli <[email protected]>
…se.asciidoc Co-authored-by: Brandon Morelli <[email protected]>
…se.asciidoc Co-authored-by: Brandon Morelli <[email protected]>
docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc
Show resolved
Hide resolved
run docs-build |
Thanks, @alaudazzi! LGTM pending these last two changes from Mykola. |
@mykolaharmash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @alaudazzi! To me this looks great ✨
1415137
@mykolaharmash @kaiyan-sheng |
From a Slack thread with @mykolaharmash:
|
@akhileshpok @mykolaharmash |
@alaudazzi - Thanks. It looks good to me! cc-@mykolaharmash |
* Add AWS Firehose quickstart * More edits * Add link to AWS integration docs * Integrate reviewers feedback * Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Integrate Mykola's feedback * Add list of parameters * Integrate reviewer feedback * Add table --------- Co-authored-by: Brandon Morelli <[email protected]> (cherry picked from commit 04b8cef)
* Add AWS Firehose quickstart * More edits * Add link to AWS integration docs * Integrate reviewers feedback * Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Integrate Mykola's feedback * Add list of parameters * Integrate reviewer feedback * Add table --------- Co-authored-by: Brandon Morelli <[email protected]> (cherry picked from commit 04b8cef)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc looks good to me.
* Add AWS Firehose quickstart * More edits * Add link to AWS integration docs * Integrate reviewers feedback * Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Integrate Mykola's feedback * Add list of parameters * Integrate reviewer feedback * Add table --------- Co-authored-by: Brandon Morelli <[email protected]> (cherry picked from commit 04b8cef) Co-authored-by: Arianna Laudazzi <[email protected]>
* Add AWS Firehose quickstart * More edits * Add link to AWS integration docs * Integrate reviewers feedback * Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/en/observability/quickstarts/collect-data-with-aws-firehose.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Integrate Mykola's feedback * Add list of parameters * Integrate reviewer feedback * Add table --------- Co-authored-by: Brandon Morelli <[email protected]> (cherry picked from commit 04b8cef) Co-authored-by: Arianna Laudazzi <[email protected]>
Description
This PR adds a new quickstart for AWS Firehose.
Documentation sets edited in this PR
Check all that apply.
docs/en/observability/*
)docs/en/serverless/*
)docs/en/integrations/*
)Related issue
Closes elastic/kibana#191835
Checklist
Follow-up tasks
Select one.