Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apm/known_issues] Add known issues for ILM to DSL switch #4192

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

lahsivjar
Copy link
Contributor

APM-Server switched from Index Lifecycle Management(ILM) to Datastream Lifecycle (DSL) in v8.15.0. This switch was done when we moved from APM integration (which used ILM) to APM-data plugin (which uses DSL) in ES for managing APM datastreams. As a result of the switch, any old datastreams created before the switch would be Unmanaged because the datastream will never be updated with the DSL lifecycle -- this has to be done manually by using the PUT API.

Related issue: elastic/apm-server#13898

@lahsivjar lahsivjar requested a review from a team as a code owner August 23, 2024 12:05
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Aug 23, 2024

This pull request does not have a backport label. Could you fix it @lahsivjar? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 23, 2024
@lahsivjar
Copy link
Contributor Author

[For reviewers] This doc update should be valid for both 8.15.1 and 8.16.0, however, the fix for 8.16.0 will probably diverge and is not in yet. I am not sure if we should only merge this for 8.15 now or for both (given that we MUST fix it for 8.16.0. CC: @simitt @endorama @inge4pres (8.15 release manager)

@lahsivjar lahsivjar added the backport-8.15 Automated backport with mergify label Aug 23, 2024
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Aug 23, 2024
@simitt
Copy link
Contributor

simitt commented Aug 23, 2024

I would say merge for 8.15.1 now, and for 8.16.0 later when it is actually fixed

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions below. Let me know if my suggestions affect accuracy.

Also, if there are any specific error messages or behaviors that would signal to the user that they are experiencing this issue, please add them here. That can help get users to this info when they search Google etc. for a specific error message or description of a particular behavior they are seeing.

docs/en/observability/apm/known-issues.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/apm/known-issues.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/apm/known-issues.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/apm/known-issues.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/apm/known-issues.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Colleen McGinnis <[email protected]>
@lahsivjar lahsivjar requested a review from simitt September 3, 2024 12:37
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some small comments

docs/en/observability/apm/known-issues.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/apm/known-issues.asciidoc Outdated Show resolved Hide resolved
simitt
simitt previously approved these changes Sep 3, 2024
colleenmcginnis
colleenmcginnis previously approved these changes Sep 3, 2024
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just suggested some minor copy edits below. 🙂

docs/en/observability/apm/known-issues.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/apm/known-issues.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/apm/known-issues.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/apm/known-issues.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Colleen McGinnis <[email protected]>
@inge4pres
Copy link
Contributor

I would say merge for 8.15.1 now, and for 8.16.0 later when it is actually fixed

IIANM we cannot do that, but we can merge this as-is for 8.16, backport to 8.15 and then once the fix is completed for 8.16 update again the main branch to amend the docs for 8.16

@simitt
Copy link
Contributor

simitt commented Sep 4, 2024

I would say merge for 8.15.1 now, and for 8.16.0 later when it is actually fixed

IIANM we cannot do that, but we can merge this as-is for 8.16, backport to 8.15 and then once the fix is completed for 8.16 update again the main branch to amend the docs for 8.16

SGTM!
Vishal is already working on also getting this fixed for 8.16, and based on latest conversations we expect 8.16 to work the same as 8.15.1.

@simitt
Copy link
Contributor

simitt commented Sep 4, 2024

@colleenmcginnis are we ok with merging this in already and also backport before the 8.15.1 release is out?

@colleenmcginnis
Copy link
Contributor

Yep! I can merge now and make sure the backport goes through successfully.

@colleenmcginnis colleenmcginnis merged commit c46cb0e into elastic:main Sep 4, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Sep 4, 2024
* Add known issues for ILM to DSL switch

* Apply suggestions from code review

Co-authored-by: Colleen McGinnis <[email protected]>

* Update ki based on recent changes

* update link of fix to the latest one

* Update wording for cause

* Avoid using abbrev for data stream lifecycle

* Apply suggestions from code review

Co-authored-by: Colleen McGinnis <[email protected]>

---------

Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit c46cb0e)
colleenmcginnis pushed a commit that referenced this pull request Sep 4, 2024
)

* Add known issues for ILM to DSL switch

* Apply suggestions from code review

Co-authored-by: Colleen McGinnis <[email protected]>

* Update ki based on recent changes

* update link of fix to the latest one

* Update wording for cause

* Avoid using abbrev for data stream lifecycle

* Apply suggestions from code review

Co-authored-by: Colleen McGinnis <[email protected]>

---------

Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit c46cb0e)

Co-authored-by: Vishal Raj <[email protected]>
@lahsivjar lahsivjar deleted the ilmdsl-ki branch September 5, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.15 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants