Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apm agentcfg api key privileges #4083

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Jul 18, 2024

Align with feature-roles.asciidoc

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Jul 18, 2024

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jul 18, 2024
@carsonip carsonip added backport-8.12 Automated backport with mergify backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify backport-8.15 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Jul 18, 2024
@carsonip carsonip marked this pull request as ready for review July 18, 2024 18:08
@carsonip carsonip requested a review from a team as a code owner July 18, 2024 18:08
@michel-laterman
Copy link
Contributor

The "cluster": ["monitor"] permission is needed when using an API key as well to retrieve the cluster_uuid

Copy link
Member Author

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apm_writer privileges are outdated as well. They are for 7.x.

@carsonip carsonip marked this pull request as draft July 23, 2024 13:38
@bmorelli25 bmorelli25 added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 12, 2024
fix apm_writer role and add allow_restricted_indices also to API PUT request
@endorama
Copy link
Member

@carsonip I updated the file aligning it to permissions as being discussed in #4193

Is there anything else needed to move forward with this?

@carsonip
Copy link
Member Author

I think you have everything covered. Do you want me to pull this out of draft and merge it, or to close this and let you handle everything in #4193?

@endorama
Copy link
Member

endorama commented Oct 1, 2024

@carsonip I would move forward and merge it, we didn't change this area in the other PR so I see little risk for conflicts.

@carsonip carsonip marked this pull request as ready for review October 1, 2024 16:01
@carsonip carsonip merged commit b83fce4 into elastic:main Oct 1, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
Align with feature-roles.asciidoc

(cherry picked from commit b83fce4)

# Conflicts:
#	docs/en/observability/apm/access-api-keys.asciidoc
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
Align with feature-roles.asciidoc

(cherry picked from commit b83fce4)
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
Align with feature-roles.asciidoc

(cherry picked from commit b83fce4)
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
Align with feature-roles.asciidoc

(cherry picked from commit b83fce4)
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
Align with feature-roles.asciidoc

(cherry picked from commit b83fce4)
colleenmcginnis pushed a commit that referenced this pull request Oct 1, 2024
Align with feature-roles.asciidoc

(cherry picked from commit b83fce4)

Co-authored-by: Carson Ip <[email protected]>
colleenmcginnis pushed a commit that referenced this pull request Oct 1, 2024
Align with feature-roles.asciidoc

(cherry picked from commit b83fce4)

Co-authored-by: Carson Ip <[email protected]>
colleenmcginnis pushed a commit that referenced this pull request Oct 1, 2024
Align with feature-roles.asciidoc

(cherry picked from commit b83fce4)

Co-authored-by: Carson Ip <[email protected]>
colleenmcginnis pushed a commit that referenced this pull request Oct 1, 2024
Align with feature-roles.asciidoc

(cherry picked from commit b83fce4)

Co-authored-by: Carson Ip <[email protected]>
colleenmcginnis added a commit that referenced this pull request Oct 1, 2024
* Fix apm agentcfg api key privileges (#4083)

Align with feature-roles.asciidoc

(cherry picked from commit b83fce4)

# Conflicts:
#	docs/en/observability/apm/access-api-keys.asciidoc

* resolve conflict

---------

Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.12 Automated backport with mergify backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify backport-8.15 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants