-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update APM URLs #3674
Update APM URLs #3674
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@bmorelli25 the broken links sections mean, that these links will forward to the new pages? I'm generally +1 on the changes, but it doesn't update the release note URLs, which I think are especially misleading with e.g. https://www.elastic.co/guide/en/observability/current/release-notes-8.12.html. Is this something that you intend to pick up later? |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, those comments were for me for debugging purposes. You can ignore them.
Fair point. Working on that in conjunction with this PR now. |
…into update-apm-urls # Conflicts: # docs/en/apm-server/redirects.asciidoc
This reverts commit 5c93068.
8e8881a
to
5e25a35
Compare
Okay, this PR is ready for review again. This PR prepends all APM URLs, including release note URLs, with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM;
@bmorelli25 are you taking care of the follow up actions mentioned in the related issue?
You'll need to collaborate with @jmlrt on updating the URLs in a follow up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…into update-apm-urls # Conflicts: # docs/en/observability/apm/command-reference.asciidoc # docs/en/observability/apm/configure/agent-config.asciidoc # docs/en/observability/apm/configure/logging.asciidoc # docs/en/observability/apm/configure/outputs/elasticsearch.asciidoc # docs/en/observability/apm/configure/outputs/kafka.asciidoc # docs/en/observability/apm/debugging.asciidoc # docs/en/observability/apm/feature-roles.asciidoc # docs/en/observability/apm/getting-started-apm-server.asciidoc # docs/en/observability/apm/https.asciidoc # docs/en/observability/apm/monitoring/monitoring-beats.asciidoc # docs/en/observability/apm/monitoring/monitoring-internal-collection.asciidoc # docs/en/observability/apm/monitoring/monitoring-metricbeat.asciidoc # docs/en/observability/apm/otel-limitations.asciidoc # docs/en/observability/apm/repositories.asciidoc # docs/en/observability/apm/shared-docker.asciidoc # docs/en/observability/apm/shared-ssl-logstash-config.asciidoc # docs/en/observability/apm/shared-systemd.asciidoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐦
(cherry picked from commit c60b759)
(cherry picked from commit c60b759) Co-authored-by: Brandon Morelli <[email protected]>
Summary
This PR updates our APM documentation by prepending the APM documentation paths with
apm-
.Task list
apm-
apm-server#12820apm-
URLs not updated
The following URLs had paths already prepended with
apm-
and thus do not need redirects:Related
For #3573.
Process
Documenting my process below in case we need to make similar changes in the future. Note that this is absolutely not performant, but it somehow does work! The bash file in step two takes ~3 minutes to run.
Find: \[\[(.+)\]\] Replace: [[apm-$1]] Include: docs/en/observability/apm
apm-*
. For each heading, this script searches for links missingapm-*
and automatically adds them.