notify main dev process when server is ready #96332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
release_note:skip
|
Pinging @elastic/kibana-core (Team:Core) |
spalger
reviewed
Apr 6, 2021
spalger
approved these changes
Apr 6, 2021
|
Thanks for hopping on this! Why do we support basePath again? Do we need it? |
|
Tested locally, since this is blocking local dev I'm going to merge early. |
@cjcenizal Best rationale for it is here https://github.com/elastic/kibana/blob/265cc7624768fef99a7cad9045a79e8610308886/packages/kbn-cli-dev-mode/README.md#basepathproxyserver, it's definitely necessary and does more than just base path stuff now. |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Apr 6, 2021
* notify main dev process when server is ready * check for process.send existence
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix dev mode being broken when using a basePath after the merge of #95510
restore the message that was sent from the legacy server to notify the main cli process that the Kibana server is ready to accept requests