Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting UI] Changed alerting UIs use new rule APIs. #96018

Merged
merged 8 commits into from
Apr 7, 2021
Merged

[Alerting UI] Changed alerting UIs use new rule APIs. #96018

merged 8 commits into from
Apr 7, 2021

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Apr 1, 2021 •
edited
Loading

Resolves #90381

Current PR has the changes:

  1. Replaced legacy alerting API with the new terminology changes

@YulNaumenko YulNaumenko self-assigned this Apr 1, 2021
@YulNaumenko YulNaumenko added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 labels Apr 1, 2021
@YulNaumenko YulNaumenko marked this pull request as ready for review April 1, 2021 22:46
@YulNaumenko YulNaumenko requested a review from a team as a code owner April 1, 2021 22:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

ymao1
ymao1 reviewed Apr 2, 2021
View reviewed changes
x-pack/plugins/triggers_actions_ui/public/application/lib/alert_api/create.ts Outdated Show resolved Hide resolved
x-pack/plugins/triggers_actions_ui/public/application/lib/alert_api/create.ts Outdated Show resolved Hide resolved
x-pack/plugins/triggers_actions_ui/public/application/lib/alert_api/common_transformations.ts Show resolved Hide resolved
x-pack/plugins/triggers_actions_ui/public/application/lib/alert_api/health.ts Outdated Show resolved Hide resolved
x-pack/plugins/triggers_actions_ui/public/application/lib/alert_api/state.ts Outdated Show resolved Hide resolved
x-pack/plugins/triggers_actions_ui/public/application/lib/alert_api/update.ts Show resolved Hide resolved
x-pack/plugins/triggers_actions_ui/public/application/lib/alert_api/update.ts Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
triggersActionsUi 346 364 +18

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.5MB 1.5MB +2.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 100.2KB 100.3KB +104.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

@YulNaumenko YulNaumenko requested a review from ymao1 April 6, 2021 00:26
ymao1
ymao1 approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YulNaumenko YulNaumenko merged commit 76ed8db into elastic:master Apr 7, 2021
@YulNaumenko YulNaumenko mentioned this pull request Apr 7, 2021
Merged
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Apr 7, 2021
@YulNaumenko
[Alerting UI] Changed alerting UIs use new rule APIs. (elastic#96018)
b9fbc9a 
* [Alerting UI] Changed alerting UIs use new rule APIs.

* added unit tests

* fixed types

* fixed types

* fixed types

* fixed due to comments
YulNaumenko added a commit that referenced this pull request Apr 7, 2021
@YulNaumenko
[Alerting UI] Changed alerting UIs use new rule APIs. (#96018) (#96426)
aedd603 
* [Alerting UI] Changed alerting UIs use new rule APIs.

* added unit tests

* fixed types

* fixed types

* fixed types

* fixed due to comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make alerting UIs use new rule APIs
4 participants
@YulNaumenko @elasticmachine @kibanamachine @ymao1