Fix missing alerts menu #94210
Merged
Fix missing alerts menu #94210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#92898 the `alerts` plugin was renamed to `alerting`. We were checking if this plugin is enabled with a check like `'alerts' in plugins`, which is not type checked. Change the check to use `!!plugins.alerting` so this type of change will be caught in the future. Rename `get_alert_capabilities` to `get_alerting_capabilities` to match the name of the exported function. Add a test for it.
smith
added
v8.0.0
release_note:skip
|
Pinging @elastic/apm-ui (Team:apm) |
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 10, 2021
In elastic#92898 the `alerts` plugin was renamed to `alerting`. We were checking if this plugin is enabled with a check like `'alerts' in plugins`, which is not type checked. Change the check to use `!!plugins.alerting` so this type of change will be caught in the future. Rename `get_alert_capabilities` to `get_alerting_capabilities` to match the name of the exported function. Add a test for it.
kibanamachine
added a commit
that referenced
this pull request
Mar 10, 2021
In #92898 the `alerts` plugin was renamed to `alerting`. We were checking if this plugin is enabled with a check like `'alerts' in plugins`, which is not type checked. Change the check to use `!!plugins.alerting` so this type of change will be caught in the future. Rename `get_alert_capabilities` to `get_alerting_capabilities` to match the name of the exported function. Add a test for it. Co-authored-by: Nathan L Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #92898 the
alertsplugin was renamed toalerting. We were checking if this plugin is enabled with a check like'alerts' in plugins, which is not type checked.Change the check to use
!!plugins.alertingso this type of change will be caught in the future.Rename
get_alert_capabilitiestoget_alerting_capabilitiesto match the name of the exported function. Add a test for it.