Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides way to exclude TS project references build from bootstrap #91209

Closed
wants to merge 4 commits into from
Closed

Provides way to exclude TS project references build from bootstrap #91209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25040df
Provides way to exclude TS project references build from bootstrap
Feb 11, 2021
e7afec5
Move to bootstrap
Feb 11, 2021
399d2d4
No longer build refs during bootstrap
Feb 11, 2021
a33f0c9
Merge branch 'master' into no-ts-refs-build
kibanamachine Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"kbn:watch": "node scripts/kibana --dev --logging.json=false",
"build:types": "rm -rf ./target/types && tsc --p tsconfig.types.json",
"docs:acceptApiChanges": "node --max-old-space-size=6144 scripts/check_published_api_changes.js --accept",
"kbn:bootstrap": "node scripts/build_ts_refs",
"kbn:bootstrap": "if [ \"$KBN_NO_BOOTSTRAP_TS_REFS\" != \"true\" ]; then node scripts/build_ts_refs; fi",
"spec_to_console": "node scripts/spec_to_console",
"backport-skip-ci": "backport --prDescription \"[skip-ci]\"",
"storybook": "node scripts/storybook",
Expand Down
6 changes: 6 additions & 0 deletions src/dev/ci_setup/setup_env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,4 +195,10 @@ fi
echo "# Appended by $KIBANA_DIR/src/dev/ci_setup/setup.sh" >> "$HOME/.bazelrc"
echo "build --remote_header=x-buildbuddy-api-key=$KIBANA_BUILDBUDDY_CI_API_KEY" >> "$HOME/.bazelrc"

###
### disables building TS project references on CI as part of bootstrap
### types will still be checked with scripts/type_check
###
export KBN_NO_BOOTSTRAP_TS_REFS=true

export CI_ENV_SETUP=true
6 changes: 6 additions & 0 deletions test/scripts/checks/build_ts_refs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/usr/bin/env bash

source src/dev/ci_setup/setup_env.sh

checks-reporter-with-killswitch "Build TS Refs" \
node scripts/build_ts_refs
1 change: 1 addition & 0 deletions test/scripts/jenkins_unit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ if [[ -z "$CODE_COVERAGE" ]] ; then
./test/scripts/checks/ts_projects.sh
./test/scripts/checks/jest_configs.sh
./test/scripts/checks/doc_api_changes.sh
./test/scripts/checks/build_ts_refs.sh
./test/scripts/checks/type_check.sh
./test/scripts/checks/bundle_limits.sh
./test/scripts/checks/i18n.sh
Expand Down