Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Remove visualize dependency #82248

Conversation

kertal
Copy link
Member

@kertal kertal commented Nov 2, 2020

Summary

This PR removes the dependency of the discover plugin on the visualizations by making direct use of data.search.aggs.createAggConfigs.

Fixes #80511

@kertal kertal added the Feature:Discover Discover Application label Nov 2, 2020
@kertal kertal requested review from timroes and majagrubic November 2, 2020 16:48
@kertal kertal self-assigned this Nov 3, 2020
@kertal kertal added Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 3, 2020
@kertal kertal marked this pull request as ready for review November 3, 2020 09:41
@kertal kertal requested a review from a team November 3, 2020 09:41
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
discover 409.9KB 409.7KB -242.0B

page load bundle size

id before after diff
discover 81.0KB 80.9KB -38.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal requested a review from stratoula November 3, 2020 09:44
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested locally in Chrome, no regression found. 🎉

@kertal kertal merged commit 677b373 into elastic:master Nov 3, 2020
kertal added a commit to kertal/kibana that referenced this pull request Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove circular dependency between discover & visualizations plugins
3 participants