[Reporting] Move a few server files for shorter paths #71591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
reporting/flatten-server-dirs
branch
from
01a8f49 to
ad869e0
Compare
tsullivan
force-pushed
the
reporting/flatten-server-dirs
branch
from
ad869e0 to
0a2b75b
Compare
tsullivan
commented
Jul 14, 2020
| import { createWorkerFactory } from './create_worker'; | ||
| // @ts-ignore | ||
| import { Esqueue } from './esqueue'; | ||
| import { createTaggedLogger } from './esqueue/create_tagged_logger'; |
There was a problem hiding this comment.
I moved this lib to the ESQueue folder so we don't forget to delete it when we delete ESQueue
tsullivan
added
chore
release_note:skip
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
spalger
approved these changes
Jul 14, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jul 14, 2020
tsullivan
added a commit
that referenced
this pull request
Jul 15, 2020
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
This reorganizes the server libs according to some goals that we were not able to get to when we moved the Reporting server code out of the legacy folder.
The new structure places libs closer to where they are used, and gets rid of unnecessary nesting.
Checklist
Delete any items that are not applicable to this PR.
For maintainers