Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Reporting/New Platform Migration] Use a new config service o… #61075

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Revert "[Reporting/New Platform Migration] Use a new config service o… #61075

merged 1 commit into from
Mar 24, 2020

Conversation

joelgriffith
Copy link
Contributor

Reverts #55882

@joelgriffith joelgriffith added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Mar 24, 2020
bmcconaghy
bmcconaghy approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joelgriffith
Copy link
Contributor Author

This was a simple, good old-fashioned:

$ git revert 5755b2ac522483bd71ad0e1b31459338ff69cf93

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joelgriffith joelgriffith merged commit 427848c into elastic:master Mar 24, 2020
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 26, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 61075 or prevent reminders by adding the backport:skip label.

@joelgriffith joelgriffith mentioned this pull request Mar 27, 2020
Closed
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 61075 or prevent reminders by adding the backport:skip label.

tsullivan added a commit to tsullivan/kibana that referenced this pull request Mar 30, 2020
@tsullivan
Revert "Revert "[Reporting/New Platform Migration] Use a new config s…
d585284 
…ervice on server-side (elastic#55882)" (elastic#61075)"

This reverts commit 427848c.
@tsullivan tsullivan mentioned this pull request Mar 30, 2020
Closed
7 tasks
@spalger spalger added the backport:skip This commit does not require backporting label Mar 31, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 31, 2020
@tsullivan tsullivan mentioned this pull request Apr 9, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmcconaghy bmcconaghy bmcconaghy approved these changes

@spalger spalger Awaiting requested review from spalger

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joelgriffith @kibanamachine @bmcconaghy @spalger