[Reporting/CSV-Panel-Action] Allow state params sent in POST payload to customize the search #34670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
tsullivan
force-pushed
the
feature/reporting/csv-export-panel-action-use-state
branch
from
80b5ffb to
97a41ea
Compare
tsullivan
force-pushed
the
feature/reporting/csv-export-panel-action-use-state
branch
from
97a41ea to
5b21113
Compare
tsullivan
changed the base branch from
master
to
feature/reporting/csv-export-panel-action
tsullivan
commented
Apr 10, 2019
| const docValueFields = indexPatternTimeField ? [indexPatternTimeField] : undefined; | ||
| const buildCsvParams: [IndexPatternSavedObject, SearchSourceQuery, Filter[], ESQueryConfig] = [ |
There was a problem hiding this comment.
Decided to do this since buildEsQuery takes complicated structures for params, but isn't in Typescript
💔 Build Failed |
💔 Build Failed |
tsullivan
added
(Deprecated) Feature:Reporting
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
tsullivan
commented
Apr 11, 2019
| * These filter types are stub types to help ensure things get passed to | ||
| * non-Typescript functions in the right order. An actual structure is not | ||
| * needed because the code doesn't look into the properties; just combines them | ||
| * and passes them through to other non-TS modules. |
There was a problem hiding this comment.
A better way to do this might be to define a module for the function I'm using that doesn't have a module definition. I don't know how to do that in TS for Kibana though :\
| range: { | ||
| [indexPatternTimeField]: { | ||
| format: 'epoch_millis', | ||
| gte: moment(timerange.min).valueOf(), |
There was a problem hiding this comment.
Are we suspect of getting that negative value here? Not sure if ES gracefully handles this at this level
joelgriffith
approved these changes
Apr 11, 2019
…/reporting/csv-export-panel-action-use-state
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
tsullivan
deleted the
feature/reporting/csv-export-panel-action-use-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The UI control passes a
stateparameter in the POST payload, intended to layer on customizations to the search: