Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index pattern management - EUI refactor #26857

Merged
merged 67 commits into from
Feb 16, 2019
Merged

Index pattern management - EUI refactor #26857

merged 67 commits into from
Feb 16, 2019

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Dec 9, 2018 •
edited
Loading

Fixes #10442

Summary

EUI refactor of index pattern list. Feature complete with previous functionality. First step in addressing https://github.com/elastic/kibana-team/issues/51

Changes

  • Replace sidebar index pattern list with full view EuiInMemoryTable
  • Display index pattern table instead of default index pattern when entering index pattern management section

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

BEFORE
screen shot 2019-02-05 at 4 25 48 pm

AFTER
screen shot 2019-02-16 at 12 48 47 pm

screen shot 2019-02-16 at 1 04 36 pm

@mattkime mattkime added the WIP Work in progress label Dec 9, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@mattkime
Copy link
Contributor Author

@ryankeairns where is $euiSizeS documented?

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor

snide commented Feb 14, 2019

where is $euiSizeS documented?

Along with all the other EUI sass

https://elastic.github.io/eui/#/guidelines/sass

@elasticmachine
Copy link
Contributor

💔 Build Failed

@ryankeairns
Copy link
Contributor

ryankeairns commented Feb 14, 2019 •
edited
Loading

@mattkime I've pushed a commit opened a PR for the header. Added a flex group... removed a flex group :) -- mattkime#5

Since the 'about' text was repeated below the h2 and on the flyout, I went a head and removed it from below the h2 so it now lives in the flyout only.

screenshot 2019-02-14 15 54 29

Thanks for tidying this stuff up!

@elasticmachine
Copy link
Contributor

💔 Build Failed

ryankeairns
ryankeairns approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mattkime mattkime removed the request for review from kobelb February 16, 2019 19:11
@mattkime mattkime merged commit 9623c64 into elastic:master Feb 16, 2019
@mattkime mattkime mentioned this pull request Feb 16, 2019
Merged
mattkime added a commit to mattkime/kibana that referenced this pull request Feb 16, 2019
@mattkime
Index pattern management - EUI refactor (elastic#26857)
732414e 
* Implement EuiInMemoryTable and Flyout, update tests
mattkime added a commit that referenced this pull request Feb 16, 2019
@mattkime
Index pattern management - EUI refactor (#26857) (#31357)
e4eaf84 
* Implement EuiInMemoryTable and Flyout, update tests
@timroes timroes mentioned this pull request Feb 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos left review comments

@lukeelmers lukeelmers lukeelmers approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees
No one assigned
Labels
release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mattkime @elasticmachine @ryankeairns @snide @cchaos @cjcenizal @lukeelmers @timroes