Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10751 app findings group by #207155

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

10751 app findings group by #207155

wants to merge 3 commits into from
+94 −70

Conversation

alexreal1314
Copy link
Contributor

Summary

This PR updates the group by mechanism with the following logic:
cloud.account.id and orchestrator.cluster.id instead of cloud.account.name and orchestrator.cluster.name for grouping on the Findings page.

Screenshots

image
image

Closes

https://github.com/elastic/security-team/issues/10751

DOD

  • Group By Cloud account should use cloud.account.id for grouping. cloud.account.name should still be displayed, for user's convenience, consult with the design
  • Group By Kubernetes cluster should use orchestrator.cluster.id for grouping. orchestrator.cluster.name should still be displayed, for user's convenience, consult with the design

@alexreal1314 alexreal1314 requested a review from a team as a code owner January 19, 2025 20:45
@alexreal1314 alexreal1314 added bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:Cloud Security Cloud Security team related labels Jan 19, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@alexreal1314 alexreal1314 added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed bug Fixes for quality problems that affect the customer experience labels Jan 19, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 19, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) good first issue low hanging fruit release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexreal1314 @elasticmachine