Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Fix small bug with copy as #206059

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Jan 9, 2025

Fixes #193048

Summary

Small mistake in the logic for setting the default language. For reproducing the bug, check the video in the attached issue.

How to test
  • Set javascript as default and cancel the form
  • See that context menu says copy as javascript
  • Change language and select python as default but copy as javascript
  • See that context says copy as python instead of javascript

@sabarasaba sabarasaba added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 9, 2025
@sabarasaba sabarasaba self-assigned this Jan 9, 2025
@sabarasaba sabarasaba marked this pull request as ready for review January 9, 2025 15:13
@sabarasaba sabarasaba requested a review from a team as a code owner January 9, 2025 15:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #59 / Serverless Observability - Deployment-agnostic API integration tests observability AI Assistant When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings "after all" hook in "When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings"
  • [job] [logs] FTR Configs #59 / Serverless Observability - Deployment-agnostic API integration tests observability AI Assistant When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings "before all" hook in "When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings"

Metrics [docs]

✅ unchanged

History

cc @sabarasaba

Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, lgtm :)

@sabarasaba sabarasaba merged commit a394ea1 into elastic:main Jan 14, 2025
11 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12763637893

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 14, 2025
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 14, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Console] Fix small bug with copy as
(#206059)](#206059)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ignacio
Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-14T08:18:35Z","message":"[Console]
Fix small bug with copy as
(#206059)","sha":"a394ea18e682336414b137edfec1cdca1249e211","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Console]
Fix small bug with copy
as","number":206059,"url":"https://github.com/elastic/kibana/pull/206059","mergeCommit":{"message":"[Console]
Fix small bug with copy as
(#206059)","sha":"a394ea18e682336414b137edfec1cdca1249e211"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206059","number":206059,"mergeCommit":{"message":"[Console]
Fix small bug with copy as
(#206059)","sha":"a394ea18e682336414b137edfec1cdca1249e211"}}]}]
BACKPORT-->

Co-authored-by: Ignacio Rivas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Console] Copy as functionality doesn't save default language if copying code in another language
4 participants