[Security Solution] List all policies to display integrations properly #205103
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkelas
added
bug
jkelas
changed the title
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
dplumlee
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
LGTM @jkelas, pulled down and tested with a couple different scenarios including the sdh-linked repro described in the initial ticket and could not reproduce the display issue
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]
History
cc @jkelas |
|
Starting backport for target branches: 8.16, 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 8, 2025
elastic#205103) **Resolves: elastic#200167** ## Summary Increase number of fetched package policies to the maximum. Currently only the first 20 policies (the first page) are returned, which results in treating all remaining ones as disabled. I am proposing the simplest change of increasing the limit here to the maximum. There shouldn't be too many policies there, e.g. in the reproduction I am running there are 23 instead of 20. If that is not enough, however, the alternative would be to discover that there are more policies than the specified limit and the next page(s) would have to be collected and the results added to the final list. #BEFORE  #AFTER  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 6d49348)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 8, 2025
elastic#205103) **Resolves: elastic#200167** ## Summary Increase number of fetched package policies to the maximum. Currently only the first 20 policies (the first page) are returned, which results in treating all remaining ones as disabled. I am proposing the simplest change of increasing the limit here to the maximum. There shouldn't be too many policies there, e.g. in the reproduction I am running there are 23 instead of 20. If that is not enough, however, the alternative would be to discover that there are more policies than the specified limit and the next page(s) would have to be collected and the results added to the final list. #BEFORE  #AFTER  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 6d49348)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 8, 2025
elastic#205103) **Resolves: elastic#200167** ## Summary Increase number of fetched package policies to the maximum. Currently only the first 20 policies (the first page) are returned, which results in treating all remaining ones as disabled. I am proposing the simplest change of increasing the limit here to the maximum. There shouldn't be too many policies there, e.g. in the reproduction I am running there are 23 instead of 20. If that is not enough, however, the alternative would be to discover that there are more policies than the specified limit and the next page(s) would have to be collected and the results added to the final list. #BEFORE  #AFTER  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 6d49348)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Jan 8, 2025
elastic#205103) **Resolves: elastic#200167** ## Summary Increase number of fetched package policies to the maximum. Currently only the first 20 policies (the first page) are returned, which results in treating all remaining ones as disabled. I am proposing the simplest change of increasing the limit here to the maximum. There shouldn't be too many policies there, e.g. in the reproduction I am running there are 23 instead of 20. If that is not enough, however, the alternative would be to discover that there are more policies than the specified limit and the next page(s) would have to be collected and the results added to the final list. #BEFORE  #AFTER  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
added a commit
that referenced
this pull request
Jan 9, 2025
…properly (#205103) (#205890) # Backport This will backport the following commits from `main` to `8.17`: - [[Security Solution] List all policies to display integrations properly (#205103)](#205103) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jacek Kolezynski","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T13:26:32Z","message":"[Security Solution] List all policies to display integrations properly (#205103)\n\n**Resolves: #200167**\n\n## Summary\n\nIncrease number of fetched package policies to the maximum. Currently\nonly the first 20 policies (the first page) are returned, which results\nin treating all remaining ones as disabled.\nI am proposing the simplest change of increasing the limit here to the\nmaximum. There shouldn't be too many policies there, e.g. in the\nreproduction I am running there are 23 instead of 20.\nIf that is not enough, however, the alternative would be to discover\nthat there are more policies than the specified limit and the next\npage(s) would have to be collected and the results added to the final\nlist.\n\n#BEFORE\n\n\n\n#AFTER \n\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6d49348db89302cf658637e8e8bd9e33760a2cad","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v8.16.3","v8.17.1"],"title":"[Security Solution] List all policies to display integrations properly","number":205103,"url":"https://github.com/elastic/kibana/pull/205103","mergeCommit":{"message":"[Security Solution] List all policies to display integrations properly (#205103)\n\n**Resolves: #200167**\n\n## Summary\n\nIncrease number of fetched package policies to the maximum. Currently\nonly the first 20 policies (the first page) are returned, which results\nin treating all remaining ones as disabled.\nI am proposing the simplest change of increasing the limit here to the\nmaximum. There shouldn't be too many policies there, e.g. in the\nreproduction I am running there are 23 instead of 20.\nIf that is not enough, however, the alternative would be to discover\nthat there are more policies than the specified limit and the next\npage(s) would have to be collected and the results added to the final\nlist.\n\n#BEFORE\n\n\n\n#AFTER \n\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6d49348db89302cf658637e8e8bd9e33760a2cad"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205103","number":205103,"mergeCommit":{"message":"[Security Solution] List all policies to display integrations properly (#205103)\n\n**Resolves: #200167**\n\n## Summary\n\nIncrease number of fetched package policies to the maximum. Currently\nonly the first 20 policies (the first page) are returned, which results\nin treating all remaining ones as disabled.\nI am proposing the simplest change of increasing the limit here to the\nmaximum. There shouldn't be too many policies there, e.g. in the\nreproduction I am running there are 23 instead of 20.\nIf that is not enough, however, the alternative would be to discover\nthat there are more policies than the specified limit and the next\npage(s) would have to be collected and the results added to the final\nlist.\n\n#BEFORE\n\n\n\n#AFTER \n\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6d49348db89302cf658637e8e8bd9e33760a2cad"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jacek Kolezynski <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 9, 2025
…roperly (#205103) (#205891) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] List all policies to display integrations properly (#205103)](#205103) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jacek Kolezynski","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T13:26:32Z","message":"[Security Solution] List all policies to display integrations properly (#205103)\n\n**Resolves: #200167**\n\n## Summary\n\nIncrease number of fetched package policies to the maximum. Currently\nonly the first 20 policies (the first page) are returned, which results\nin treating all remaining ones as disabled.\nI am proposing the simplest change of increasing the limit here to the\nmaximum. There shouldn't be too many policies there, e.g. in the\nreproduction I am running there are 23 instead of 20.\nIf that is not enough, however, the alternative would be to discover\nthat there are more policies than the specified limit and the next\npage(s) would have to be collected and the results added to the final\nlist.\n\n#BEFORE\n\n\n\n#AFTER \n\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6d49348db89302cf658637e8e8bd9e33760a2cad","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v8.16.3","v8.17.1"],"title":"[Security Solution] List all policies to display integrations properly","number":205103,"url":"https://github.com/elastic/kibana/pull/205103","mergeCommit":{"message":"[Security Solution] List all policies to display integrations properly (#205103)\n\n**Resolves: #200167**\n\n## Summary\n\nIncrease number of fetched package policies to the maximum. Currently\nonly the first 20 policies (the first page) are returned, which results\nin treating all remaining ones as disabled.\nI am proposing the simplest change of increasing the limit here to the\nmaximum. There shouldn't be too many policies there, e.g. in the\nreproduction I am running there are 23 instead of 20.\nIf that is not enough, however, the alternative would be to discover\nthat there are more policies than the specified limit and the next\npage(s) would have to be collected and the results added to the final\nlist.\n\n#BEFORE\n\n\n\n#AFTER \n\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6d49348db89302cf658637e8e8bd9e33760a2cad"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205103","number":205103,"mergeCommit":{"message":"[Security Solution] List all policies to display integrations properly (#205103)\n\n**Resolves: #200167**\n\n## Summary\n\nIncrease number of fetched package policies to the maximum. Currently\nonly the first 20 policies (the first page) are returned, which results\nin treating all remaining ones as disabled.\nI am proposing the simplest change of increasing the limit here to the\nmaximum. There shouldn't be too many policies there, e.g. in the\nreproduction I am running there are 23 instead of 20.\nIf that is not enough, however, the alternative would be to discover\nthat there are more policies than the specified limit and the next\npage(s) would have to be collected and the results added to the final\nlist.\n\n#BEFORE\n\n\n\n#AFTER \n\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6d49348db89302cf658637e8e8bd9e33760a2cad"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jacek Kolezynski <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 9, 2025
…properly (#205103) (#205889) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution] List all policies to display integrations properly (#205103)](#205103) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jacek Kolezynski","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T13:26:32Z","message":"[Security Solution] List all policies to display integrations properly (#205103)\n\n**Resolves: #200167**\n\n## Summary\n\nIncrease number of fetched package policies to the maximum. Currently\nonly the first 20 policies (the first page) are returned, which results\nin treating all remaining ones as disabled.\nI am proposing the simplest change of increasing the limit here to the\nmaximum. There shouldn't be too many policies there, e.g. in the\nreproduction I am running there are 23 instead of 20.\nIf that is not enough, however, the alternative would be to discover\nthat there are more policies than the specified limit and the next\npage(s) would have to be collected and the results added to the final\nlist.\n\n#BEFORE\n\n\n\n#AFTER \n\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6d49348db89302cf658637e8e8bd9e33760a2cad","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v8.16.3","v8.17.1"],"title":"[Security Solution] List all policies to display integrations properly","number":205103,"url":"https://github.com/elastic/kibana/pull/205103","mergeCommit":{"message":"[Security Solution] List all policies to display integrations properly (#205103)\n\n**Resolves: #200167**\n\n## Summary\n\nIncrease number of fetched package policies to the maximum. Currently\nonly the first 20 policies (the first page) are returned, which results\nin treating all remaining ones as disabled.\nI am proposing the simplest change of increasing the limit here to the\nmaximum. There shouldn't be too many policies there, e.g. in the\nreproduction I am running there are 23 instead of 20.\nIf that is not enough, however, the alternative would be to discover\nthat there are more policies than the specified limit and the next\npage(s) would have to be collected and the results added to the final\nlist.\n\n#BEFORE\n\n\n\n#AFTER \n\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6d49348db89302cf658637e8e8bd9e33760a2cad"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205103","number":205103,"mergeCommit":{"message":"[Security Solution] List all policies to display integrations properly (#205103)\n\n**Resolves: #200167**\n\n## Summary\n\nIncrease number of fetched package policies to the maximum. Currently\nonly the first 20 policies (the first page) are returned, which results\nin treating all remaining ones as disabled.\nI am proposing the simplest change of increasing the limit here to the\nmaximum. There shouldn't be too many policies there, e.g. in the\nreproduction I am running there are 23 instead of 20.\nIf that is not enough, however, the alternative would be to discover\nthat there are more policies than the specified limit and the next\npage(s) would have to be collected and the results added to the final\nlist.\n\n#BEFORE\n\n\n\n#AFTER \n\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6d49348db89302cf658637e8e8bd9e33760a2cad"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jacek Kolezynski <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
elastic#205103) **Resolves: elastic#200167** ## Summary Increase number of fetched package policies to the maximum. Currently only the first 20 policies (the first page) are returned, which results in treating all remaining ones as disabled. I am proposing the simplest change of increasing the limit here to the maximum. There shouldn't be too many policies there, e.g. in the reproduction I am running there are 23 instead of 20. If that is not enough, however, the alternative would be to discover that there are more policies than the specified limit and the next page(s) would have to be collected and the results added to the final list. #BEFORE  #AFTER  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This was referenced Jan 17, 2025
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
elastic#205103) **Resolves: elastic#200167** ## Summary Increase number of fetched package policies to the maximum. Currently only the first 20 policies (the first page) are returned, which results in treating all remaining ones as disabled. I am proposing the simplest change of increasing the limit here to the maximum. There shouldn't be too many policies there, e.g. in the reproduction I am running there are 23 instead of 20. If that is not enough, however, the alternative would be to discover that there are more policies than the specified limit and the next page(s) would have to be collected and the results added to the final list. #BEFORE  #AFTER  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #200167
Summary
Increase number of fetched package policies to the maximum. Currently only the first 20 policies (the first page) are returned, which results in treating all remaining ones as disabled.
I am proposing the simplest change of increasing the limit here to the maximum. There shouldn't be too many policies there, e.g. in the reproduction I am running there are 23 instead of 20.
If that is not enough, however, the alternative would be to discover that there are more policies than the specified limit and the next page(s) would have to be collected and the results added to the final list.
#BEFORE
#AFTER
Checklist