Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x][Dataset Quality] Reclassify modules as "platform/shared" #204991

Merged
merged 2 commits into from
Dec 19, 2024
Merged

[8.x][Dataset Quality] Reclassify modules as "platform/shared" #204991

merged 2 commits into from
Dec 19, 2024

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Dec 19, 2024

Backport

This will backport the following commits from main to 8.x:

@weltenwort @kibanamachine
@elasticmachine @yngrdyn
[Dataset Quality] Reclassify modules as "platform/shared" (elastic#20…
cac49eb 
…4052)

This reclassifies the plugins `@kbn/data-quality-plugin` and
`@kbn/dataset-quality-plugin` as `platform/shared`, because they're not
specific observability despite the code ownership.

- partly addresses:
elastic/observability-dev#4059

- One small utility hook was copied from
`@kbn/observability-shared-plugin` to remove a forbidden dependency.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Dec 19, 2024
@yngrdyn yngrdyn enabled auto-merge (squash) December 19, 2024 18:04
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 19, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 2c858ca
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-204991-2c858caeb05f

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
datasetQuality 277 272 -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 252.1KB 252.1KB -34.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
datasetQuality 18.9KB 18.9KB +20.0B

History

@yngrdyn yngrdyn merged commit c986805 into elastic:8.x Dec 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbamparop gbamparop gbamparop approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yngrdyn @elasticmachine @gbamparop @weltenwort @kibanamachine