Sustainable Kibana Architecture: Move plugins owned by `@elastic/appex-sharedux` #204959

Dosant · 2024-12-19T14:33:27Z

Summary

Part of #203163

Relocating only shared-ux-owned plugins for now . Tip on how to review changes if GitHub UI is unmanageable - https://elastic.slack.com/archives/C07TCKTA22E/p1734606026689389

node scripts/relocate.js --include "@kbn/advanced-settings-plugin" --include "@kbn/banners-plugin" --include "@kbn/content-management-plugin" --include "@kbn/custom-branding-plugin" --include "@kbn/files-management-plugin" --include "@kbn/files-plugin" --include "@kbn/global-search-bar-plugin" --include "@kbn/global-search-plugin" --include "@kbn/global-search-providers-plugin" --include "@kbn/guided-onboarding-plugin" --include "@kbn/home-plugin" --include "@kbn/image-embeddable-plugin" --include "@kbn/kibana-overview-plugin" --include "@kbn/kibana-react-plugin" --include "@kbn/kibana-utils-plugin" --include "@kbn/navigation-plugin" --include "@kbn/no-data-page-plugin" --include "@kbn/notifications-plugin" --include "@kbn/reporting-plugin" --include "@kbn/saved-objects-plugin" --include "@kbn/saved-objects-tagging-oss-plugin" --include "@kbn/saved-objects-tagging-plugin" --include "@kbn/screenshot-mode-plugin" --include "@kbn/serverless" --include "@kbn/share-plugin" --include --include "@kbn/ui-actions-enhanced-plugin" --include "@kbn/ui-actions-plugin"

  ┌─────────────────────────────────────────┬───────────────────────────────────────────────────────────┐
  │  Id                                     │  Target folder                                            │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/content-management-plugin         │  src/platform/plugins/shared/content_management           │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/custom-branding-plugin            │  x-pack/platform/plugins/private/custom_branding          │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/files-management-plugin           │  src/platform/plugins/private/files_management            │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/files-plugin                      │  src/platform/plugins/shared/files                        │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/global-search-bar-plugin          │  x-pack/platform/plugins/private/global_search_bar        │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/global-search-plugin              │  x-pack/platform/plugins/shared/global_search             │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/global-search-providers-plugin    │  x-pack/platform/plugins/private/global_search_providers  │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/guided-onboarding-plugin          │  src/platform/plugins/shared/guided_onboarding            │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/home-plugin                       │  src/platform/plugins/shared/home                         │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/image-embeddable-plugin           │  src/platform/plugins/private/image_embeddable            │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/kibana-overview-plugin            │  src/platform/plugins/private/kibana_overview             │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/kibana-react-plugin               │  src/platform/plugins/shared/kibana_react                 │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/kibana-utils-plugin               │  src/platform/plugins/shared/kibana_utils                 │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/navigation-plugin                 │  src/platform/plugins/shared/navigation                   │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/no-data-page-plugin               │  src/platform/plugins/private/no_data_page                │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/notifications-plugin              │  x-pack/platform/plugins/shared/notifications             │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/reporting-plugin                  │  x-pack/platform/plugins/private/reporting                │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/saved-objects-plugin              │  src/platform/plugins/shared/saved_objects                │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/saved-objects-tagging-oss-plugin  │  src/platform/plugins/shared/saved_objects_tagging_oss    │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/saved-objects-tagging-plugin      │  x-pack/platform/plugins/private/saved_objects_tagging    │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/screenshot-mode-plugin            │  src/platform/plugins/shared/screenshot_mode              │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/serverless                        │  x-pack/platform/plugins/shared/serverless                │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/share-plugin                      │  src/platform/plugins/shared/share                        │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/ui-actions-enhanced-plugin        │  src/platform/plugins/shared/ui_actions_enhanced          │
  ├─────────────────────────────────────────┼───────────────────────────────────────────────────────────┤
  │  @kbn/ui-actions-plugin                 │  src/platform/plugins/shared/ui_actions                   │
  └─────────────────────────────────────────┴───────────────────────────────────────────────────────────┘

github-actions · 2024-12-19T14:33:42Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

elasticmachine · 2024-12-20T13:38:50Z

Pinging @elastic/appex-sharedux (Team:SharedUX)

dmlemeshko

appex-qa changes LGTM

gsoldevila

🚀

Dosant · 2024-12-23T09:04:41Z

@elasticmachine merge upstream

szwarckonrad

DW changes are only related to a single URL in a comment.

delanni · 2024-12-23T10:04:03Z

.buildkite/scripts/pipelines/pull_request/pipeline.ts

@@ -164,8 +164,8 @@ const getPipeline = (filename: string, removeSteps = true) => {
    if (
      (await doAnyChangesMatch([
        /^x-pack\/platform\/packages\/shared\/ai-infra/,
-        /^x-pack\/platform\/plugins\/shared\/ai_infra/,
-        /^x-pack\/platform\/plugins\/shared\/inference/,
+        /^x-pack\/platform\/platform\/plugins\/shared\/shared\/ai_infra/,


These paths don't look right, the "platform" part seems duplicated. (More occurrences in the file)

Thank you! adjusted manually

cc @gsoldevila

delanni

Paths testing in pipeline.ts doesn't look right

…sant/kibana into kbn-team-1309-relocate-20241219135219

PhilippeOberti

single file impact, change LGTM for the Threat Hunting Investigations team

mattkime

codeowner changes lgtm

…elocate-20241219135219

elasticmachine · 2024-12-23T20:13:11Z

💛 Build succeeded, but was flaky

Failed CI Steps

Jest Tests #9

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`kibanaReact`	197.2KB	197.1KB	-12.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kibanaReact`	40.0KB	39.6KB	-421.0B

History

💛 Build #262754 was flaky 17c895c
💚 Build #262706 succeeded efed50c
💚 Build #262615 succeeded b53c743
💔 Build #262614 failed 2d61407
💔 Build #262451 failed 4df790e
💔 Build #262413 failed fd501db

Dosant added 25 commits December 19, 2024 14:54

Relocating module @kbn/content-management-plugin

3c34745

Relocating module @kbn/custom-branding-plugin

f9a24a5

Relocating module @kbn/files-management-plugin

9c66dc1

Relocating module @kbn/files-plugin

502f6e9

Relocating module @kbn/global-search-bar-plugin

b6fbaae

Relocating module @kbn/global-search-plugin

25687eb

Relocating module @kbn/global-search-providers-plugin

72bc3ab

Relocating module @kbn/guided-onboarding-plugin

82904c4

Relocating module @kbn/home-plugin

0e789d4

Relocating module @kbn/image-embeddable-plugin

113e536

Relocating module @kbn/kibana-overview-plugin

d565add

Relocating module @kbn/kibana-react-plugin

2d75db9

Relocating module @kbn/kibana-utils-plugin

72c936e

Relocating module @kbn/navigation-plugin

1f3b4de

Relocating module @kbn/no-data-page-plugin

adcff47

Relocating module @kbn/notifications-plugin

df2e448

Relocating module @kbn/reporting-plugin

a64deb7

Relocating module @kbn/saved-objects-plugin

7fac4cd

Relocating module @kbn/saved-objects-tagging-oss-plugin

e9c2c94

Relocating module @kbn/saved-objects-tagging-plugin

7be74c3

Relocating module @kbn/screenshot-mode-plugin

87a16af

Relocating module @kbn/serverless

5e42148

Relocating module @kbn/share-plugin

bd9a8ff

Relocating module @kbn/ui-actions-enhanced-plugin

cbc98ce

Relocating module @kbn/ui-actions-plugin

6620fe5

Dosant changed the title ~~Kbn team 1309 relocate 20241219135219~~ Sustainable Kibana Architecture: Move plugins owned by @elastic/appex-sharedux Dec 19, 2024

Dosant added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 19, 2024

Dosant requested review from a team as code owners December 20, 2024 13:38

Dosant requested review from ashokaditya and szwarckonrad December 20, 2024 13:38

dmlemeshko approved these changes Dec 20, 2024

View reviewed changes

gsoldevila approved these changes Dec 20, 2024

View reviewed changes

Merge branch 'main' into kbn-team-1309-relocate-20241219135219

efed50c

sebelga approved these changes Dec 23, 2024

View reviewed changes

szwarckonrad approved these changes Dec 23, 2024

View reviewed changes

delanni reviewed Dec 23, 2024

View reviewed changes

Dosant added 5 commits December 23, 2024 12:48

fix pipeline.ts

a339856

Merge branch 'kbn-team-1309-relocate-20241219135219' of github.com:Do…

0df41b5

…sant/kibana into kbn-team-1309-relocate-20241219135219

fix pipeline.ts

d3fe46a

fix pipeline.ts

1251c5f

fix i18nrc.json

17c895c

delanni approved these changes Dec 23, 2024

View reviewed changes

nickpeihl approved these changes Dec 23, 2024

View reviewed changes

PhilippeOberti approved these changes Dec 23, 2024

View reviewed changes

mattkime approved these changes Dec 23, 2024

View reviewed changes

Merge branch 'main' of github.com:elastic/kibana into kbn-team-1309-r…

fad8a41

…elocate-20241219135219

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sustainable Kibana Architecture: Move plugins owned by `@elastic/appex-sharedux` #204959

Sustainable Kibana Architecture: Move plugins owned by `@elastic/appex-sharedux` #204959

Dosant commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024

elasticmachine commented Dec 20, 2024

dmlemeshko left a comment

gsoldevila left a comment

Dosant commented Dec 23, 2024

szwarckonrad left a comment

delanni Dec 23, 2024

Dosant Dec 23, 2024

delanni left a comment •

edited

Loading

PhilippeOberti left a comment

mattkime left a comment

elasticmachine commented Dec 23, 2024

Sustainable Kibana Architecture: Move plugins owned by @elastic/appex-sharedux #204959

Are you sure you want to change the base?

Sustainable Kibana Architecture: Move plugins owned by @elastic/appex-sharedux #204959

Conversation

Dosant commented Dec 19, 2024 • edited Loading

Summary

github-actions bot commented Dec 19, 2024

elasticmachine commented Dec 20, 2024

dmlemeshko left a comment

Choose a reason for hiding this comment

gsoldevila left a comment

Choose a reason for hiding this comment

Dosant commented Dec 23, 2024

szwarckonrad left a comment

Choose a reason for hiding this comment

delanni Dec 23, 2024

Choose a reason for hiding this comment

Dosant Dec 23, 2024

Choose a reason for hiding this comment

delanni left a comment • edited Loading

Choose a reason for hiding this comment

PhilippeOberti left a comment

Choose a reason for hiding this comment

mattkime left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 23, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Page load bundle

History

Sustainable Kibana Architecture: Move plugins owned by `@elastic/appex-sharedux` #204959

Sustainable Kibana Architecture: Move plugins owned by `@elastic/appex-sharedux` #204959

Dosant commented Dec 19, 2024 •

edited

Loading

delanni left a comment •

edited

Loading