Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Reintroduce ESQL request count tests #204925

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

kertal
Copy link
Member

@kertal kertal commented Dec 19, 2024

Summary

This PR reintroduces and improves the tests that were removed in #174246 checking for how much requests are submitted in Discover when using ES|QL.

Checklist

@kertal
Copy link
Member Author

kertal commented Dec 19, 2024

/ci

@kertal
Copy link
Member Author

kertal commented Dec 19, 2024

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7621

[✅] test/functional/apps/discover/group3/config.ts: 25/25 tests passed.

see run history

@kertal kertal self-assigned this Dec 19, 2024
@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:ES|QL ES|QL related features in Kibana backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 19, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7623

[✅] test/functional/apps/discover/group3/config.ts: 25/25 tests passed.

see run history

@kertal kertal marked this pull request as ready for review December 19, 2024 14:01
@kertal kertal requested a review from a team as a code owner December 19, 2024 14:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

test/functional/apps/discover/group3/_request_counts.ts Outdated Show resolved Hide resolved
@kertal kertal enabled auto-merge (squash) December 19, 2024 14:57
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner December 19, 2024 15:16
@kertal kertal added the release_note:skip Skip the PR/issue when compiling release notes label Dec 19, 2024
@kertal kertal merged commit fa30292 into elastic:main Dec 19, 2024
9 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @kertal

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12418853018

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 19, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 19, 2024
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Discover] Reintroduce ESQL request count tests
(#204925)](#204925)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthias
Wilhelm","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T18:44:25Z","message":"[Discover]
Reintroduce ESQL request count tests
(#204925)","sha":"fa3029225ae386a71f0109132354746a75201dd7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","Feature:ES|QL"],"title":"[Discover]
Reintroduce ESQL request count
tests","number":204925,"url":"https://github.com/elastic/kibana/pull/204925","mergeCommit":{"message":"[Discover]
Reintroduce ESQL request count tests
(#204925)","sha":"fa3029225ae386a71f0109132354746a75201dd7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204925","number":204925,"mergeCommit":{"message":"[Discover]
Reintroduce ESQL request count tests
(#204925)","sha":"fa3029225ae386a71f0109132354746a75201dd7"}}]}]
BACKPORT-->

Co-authored-by: Matthias Wilhelm <[email protected]>
stratoula pushed a commit to stratoula/kibana that referenced this pull request Jan 2, 2025
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants