[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-reporting-services (#202741)

.github/CODEOWNERS

@@ -784,7 +784,7 @@ packages/kbn-scout-reporting @elastic/appex-qa
 examples/screenshot_mode_example @elastic/appex-sharedux
 src/plugins/screenshot_mode @elastic/appex-sharedux
 x-pack/examples/screenshotting_example @elastic/appex-sharedux
-x-pack/plugins/screenshotting @elastic/kibana-reporting-services
+x-pack/platform/plugins/shared/screenshotting @elastic/kibana-reporting-services
 packages/kbn-screenshotting-server @elastic/appex-sharedux
 packages/kbn-search-api-keys-components @elastic/search-kibana
 packages/kbn-search-api-keys-server @elastic/search-kibana

docs/developer/plugin-list.asciidoc

@@ -811,7 +811,7 @@ Elastic.
 |Add tagging capability to saved objects
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/screenshotting/README.md[screenshotting]
+|{kib-repo}blob/{branch}/x-pack/platform/plugins/shared/screenshotting/README.md[screenshotting]
 |This plugin provides functionality to take screenshots of the Kibana pages.
 It uses Chromium and Puppeteer underneath to run the browser in headless mode.
 

package.json

@@ -793,7 +793,7 @@
     "@kbn/screenshot-mode-example-plugin": "link:examples/screenshot_mode_example",
     "@kbn/screenshot-mode-plugin": "link:src/plugins/screenshot_mode",
     "@kbn/screenshotting-example-plugin": "link:x-pack/examples/screenshotting_example",
-    "@kbn/screenshotting-plugin": "link:x-pack/plugins/screenshotting",
+    "@kbn/screenshotting-plugin": "link:x-pack/platform/plugins/shared/screenshotting",
     "@kbn/screenshotting-server": "link:packages/kbn-screenshotting-server",
     "@kbn/search-api-keys-components": "link:packages/kbn-search-api-keys-components",
     "@kbn/search-api-keys-server": "link:packages/kbn-search-api-keys-server",

packages/kbn-cli-dev-mode/src/watcher.ts

@@ -19,7 +19,7 @@ import { Log } from './log';
 const packageMatcher = makeMatcher([
   '**/*',
   '!**/.*',
-  '!x-pack/plugins/screenshotting/chromium/**',
+  '!x-pack/platform/plugins/shared/screenshotting/chromium/**',
   '!x-pack/plugins/canvas/shareable_runtime/**',
 ]);
 

src/dev/code_coverage/ingest_coverage/__tests__/enumerate_patterns.test.js

@@ -17,13 +17,13 @@ const log = new ToolingLog({
 });
 
 describe(`enumeratePatterns`, () => {
-  it(`should resolve x-pack/plugins/screenshotting/server/browsers/extract/unzip.ts to kibana-screenshotting`, () => {
+  it(`should resolve x-pack/platform/plugins/shared/screenshotting/server/browsers/extract/unzip.ts to kibana-screenshotting`, () => {
     const actual = enumeratePatterns(REPO_ROOT)(log)(
-      new Map([['x-pack/plugins/screenshotting', ['kibana-screenshotting']]])
+      new Map([['x-pack/platform/plugins/shared/screenshotting', ['kibana-screenshotting']]])
     );
 
     expect(actual.flat()).toContain(
-      'x-pack/plugins/screenshotting/server/browsers/extract/unzip.ts kibana-screenshotting'
+      'x-pack/platform/plugins/shared/screenshotting/server/browsers/extract/unzip.ts kibana-screenshotting'
     );
   });
   it(`should resolve src/plugins/charts/common/static/color_maps/color_maps.ts to kibana-app`, () => {

src/dev/precommit_hook/casing_check_config.js

@@ -178,10 +178,10 @@ export const TEMPORARILY_IGNORED_PATHS = [
   'x-pack/plugins/monitoring/public/icons/health-green.svg',
   'x-pack/plugins/monitoring/public/icons/health-red.svg',
   'x-pack/plugins/monitoring/public/icons/health-yellow.svg',
-  'x-pack/plugins/screenshotting/server/assets/fonts/noto/NotoSansCJKtc-Medium.ttf',
-  'x-pack/plugins/screenshotting/server/assets/fonts/noto/NotoSansCJKtc-Regular.ttf',
-  'x-pack/plugins/screenshotting/server/assets/fonts/roboto/Roboto-Italic.ttf',
-  'x-pack/plugins/screenshotting/server/assets/fonts/roboto/Roboto-Medium.ttf',
-  'x-pack/plugins/screenshotting/server/assets/fonts/roboto/Roboto-Regular.ttf',
-  'x-pack/plugins/screenshotting/server/assets/img/logo-grey.png',
+  'x-pack/platform/plugins/shared/screenshotting/server/assets/fonts/noto/NotoSansCJKtc-Medium.ttf',
+  'x-pack/platform/plugins/shared/screenshotting/server/assets/fonts/noto/NotoSansCJKtc-Regular.ttf',
+  'x-pack/platform/plugins/shared/screenshotting/server/assets/fonts/roboto/Roboto-Italic.ttf',
+  'x-pack/platform/plugins/shared/screenshotting/server/assets/fonts/roboto/Roboto-Medium.ttf',
+  'x-pack/platform/plugins/shared/screenshotting/server/assets/fonts/roboto/Roboto-Regular.ttf',
+  'x-pack/platform/plugins/shared/screenshotting/server/assets/img/logo-grey.png',
 ];

tsconfig.base.json

@@ -1562,8 +1562,8 @@
       "@kbn/screenshot-mode-plugin/*": ["src/plugins/screenshot_mode/*"],
       "@kbn/screenshotting-example-plugin": ["x-pack/examples/screenshotting_example"],
       "@kbn/screenshotting-example-plugin/*": ["x-pack/examples/screenshotting_example/*"],
-      "@kbn/screenshotting-plugin": ["x-pack/plugins/screenshotting"],
-      "@kbn/screenshotting-plugin/*": ["x-pack/plugins/screenshotting/*"],
+      "@kbn/screenshotting-plugin": ["x-pack/platform/plugins/shared/screenshotting"],
+      "@kbn/screenshotting-plugin/*": ["x-pack/platform/plugins/shared/screenshotting/*"],
       "@kbn/screenshotting-server": ["packages/kbn-screenshotting-server"],
       "@kbn/screenshotting-server/*": ["packages/kbn-screenshotting-server/*"],
       "@kbn/search-api-keys-components": ["packages/kbn-search-api-keys-components"],

x-pack/.gitignore

@@ -6,7 +6,7 @@
 /test/functional/apps/**/reports/session
 /test/reporting/configs/failure_debug/
 /plugins/reporting/.chromium/
-/plugins/screenshotting/chromium/
+/platform/plugins/shared/screenshotting/chromium/
 /plugins/reporting/.phantom/
 /.aws-config.json
 /.env

x-pack/.i18nrc.json

@@ -107,7 +107,7 @@
     "xpack.reporting": ["plugins/reporting"],
     "xpack.rollupJobs": ["platform/packages/private/rollup", "platform/plugins/private/rollup"],
     "xpack.runtimeFields": "platform/plugins/private/runtime_fields",
-    "xpack.screenshotting": "plugins/screenshotting",
+    "xpack.screenshotting": "platform/plugins/shared/screenshotting",
     "xpack.searchSharedUI": "packages/search/shared_ui",
     "xpack.searchHomepage": "plugins/search_homepage",
     "xpack.searchIndices": "plugins/search_indices",

x-pack/plugins/screenshotting/README.md → x-pack/platform/plugins/shared/screenshotting/README.md

@@ -24,7 +24,7 @@ Here is an example of how you can take a screenshot of a Kibana URL.
 ```typescript
 import { lastValueFrom } from 'rxjs';
 import type { CoreSetup, Plugin } from 'src/core/server';
-import type { ScreenshottingStart } from 'x-pack/plugins/screenshotting/server';
+import type { ScreenshottingStart } from 'x-pack/platform/plugins/shared/screenshotting/server';
 
 
 interface StartDeps {

x-pack/plugins/screenshotting/jest.config.js → x-pack/platform/plugins/shared/screenshotting/jest.config.js

@@ -7,9 +7,10 @@
 
 module.exports = {
   preset: '@kbn/test',
-  rootDir: '../../..',
-  roots: ['<rootDir>/x-pack/plugins/screenshotting'],
-  coverageDirectory: '<rootDir>/target/kibana-coverage/jest/x-pack/plugins/screenshotting',
+  rootDir: '../../../../..',
+  roots: ['<rootDir>/x-pack/platform/plugins/shared/screenshotting'],
+  coverageDirectory:
+    '<rootDir>/target/kibana-coverage/jest/x-pack/platform/plugins/shared/screenshotting',
   coverageReporters: ['text', 'html'],
-  collectCoverageFrom: ['<rootDir>/x-pack/plugins/screenshotting/server/**/*.{ts}'],
+  collectCoverageFrom: ['<rootDir>/x-pack/platform/plugins/shared/screenshotting/server/**/*.{ts}'],
 };

x-pack/plugins/screenshotting/jest.integration.config.js → x-pack/platform/plugins/shared/screenshotting/jest.integration.config.js

@@ -7,6 +7,6 @@
 
 module.exports = {
   preset: '@kbn/test/jest_integration',
-  rootDir: '../../..',
-  roots: ['<rootDir>/x-pack/plugins/screenshotting'],
+  rootDir: '../../../../..',
+  roots: ['<rootDir>/x-pack/platform/plugins/shared/screenshotting'],
 };

x-pack/plugins/screenshotting/server/formats/pdf/pdf_maker/worker_src_harness.js → x-pack/platform/plugins/shared/screenshotting/server/formats/pdf/pdf_maker/worker_src_harness.js

@@ -11,6 +11,6 @@
  */
 
 // eslint-disable-next-line @kbn/imports/no_boundary_crossing
-require('../../../../../../../src/setup_node_env');
+require('../../../../../../../../../src/setup_node_env');
 // eslint-disable-next-line @kbn/imports/uniform_imports
 require('./worker.ts');

x-pack/plugins/screenshotting/server/screenshots/screenshots.test.ts → x-pack/platform/plugins/shared/screenshotting/server/screenshots/screenshots.test.ts

@@ -30,7 +30,8 @@ describe('class Screenshots', () => {
   let mockLogger: Logger;
   let mockScreenshotModeSetup: ScreenshotModePluginSetup;
 
-  const mockBinaryPath = '/kibana/x-pack/plugins/screenshotting/chromium/linux/headless_shell';
+  const mockBinaryPath =
+    '/kibana/x-pack/platform/plugins/shared/screenshotting/chromium/linux/headless_shell';
   const mockBasePath = '/kibanaTest1';
 
   beforeEach(() => {

x-pack/plugins/screenshotting/tsconfig.json → x-pack/platform/plugins/shared/screenshotting/tsconfig.json

@@ -1,17 +1,17 @@
 {
-  "extends": "../../../tsconfig.base.json",
+  "extends": "../../../../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "target/types",
   },
   "include": [
     "common/**/*",
     "public/**/*",
     "server/**/*",
-    "../../../typings/**/*"
+    "../../../../../typings/**/*"
   ],
   "kbn_references": [
     "@kbn/core",
-    { "path": "../../../src/setup_node_env/tsconfig.json" },
+    { "path": "../../../../../src/setup_node_env/tsconfig.json" },
     "@kbn/expressions-plugin",
     "@kbn/screenshot-mode-plugin",
     "@kbn/cloud-plugin",

x-pack/plugins/lens/public/app_plugin/share_action.ts

@@ -31,7 +31,7 @@ interface ShareableConfiguration
 export const DEFAULT_LENS_LAYOUT_DIMENSIONS = {
   width: 1793,
   // this is a magic number from the reporting tool implementation
-  // see: x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/index.ts#L146
+  // see: x-pack/platform/plugins/shared/screenshotting/server/browsers/chromium/driver_factory/index.ts#L146
   height: 1086,
 };
 

yarn.lock

@@ -6931,7 +6931,7 @@
   version "0.0.0"
   uid ""
 
-"@kbn/screenshotting-plugin@link:x-pack/plugins/screenshotting":
+"@kbn/screenshotting-plugin@link:x-pack/platform/plugins/shared/screenshotting":
   version "0.0.0"
   uid ""