Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES body removal] @elastic/fleet #204867

Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented Dec 19, 2024

Summary

Attempt to remove the deprecated body in the ES client.

@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 19, 2024
@afharo afharo self-assigned this Dec 19, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #5 / management index management Inference endpoints create inference endpoint
  • [job] [logs] Jest Tests #10 / StepDefineRule required fields submits newly added required fields

Metrics [docs]

✅ unchanged

History

cc @afharo

@afharo afharo marked this pull request as ready for review December 19, 2024 12:56
@afharo afharo requested a review from a team as a code owner December 19, 2024 12:56
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM 🚀 I did a quick test of Fleet and it seems to work as expected

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@afharo afharo merged commit d7ef161 into elastic:main Dec 19, 2024
11 checks passed
@afharo afharo deleted the esclient/remove-deprecated-body/elastic/fleet branch December 19, 2024 20:09
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12420018195

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 204867

Questions ?

Please refer to the Backport tool documentation

@afharo
Copy link
Member Author

afharo commented Dec 19, 2024

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

afharo added a commit that referenced this pull request Dec 19, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES `body` removal] `@elastic/fleet`
(#204867)](#204867)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T20:09:27Z","message":"[ES
`body` removal] `@elastic/fleet` (#204867)\n\n## Summary\n\nAttempt to
remove the deprecated `body` in the ES
client.","sha":"d7ef161d8d8ddcfe652bb607a0c01002e985eae6","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"number":204867,"url":"https://github.com/elastic/kibana/pull/204867","mergeCommit":{"message":"[ES
`body` removal] `@elastic/fleet` (#204867)\n\n## Summary\n\nAttempt to
remove the deprecated `body` in the ES
client.","sha":"d7ef161d8d8ddcfe652bb607a0c01002e985eae6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204867","number":204867,"mergeCommit":{"message":"[ES
`body` removal] `@elastic/fleet` (#204867)\n\n## Summary\n\nAttempt to
remove the deprecated `body` in the ES
client.","sha":"d7ef161d8d8ddcfe652bb607a0c01002e985eae6"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants