[Fleet] Agent upgrade form validation fix #204846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om submitting when there are errors in the version
Supplementing
added
bug
|
Pinging @elastic/fleet (Team:Fleet) |
|
Additionally, in order to fix failed checks, I removed the 'selectedVersionStr' definition as it wasn't being used for anything. Now that I think about it more, we should probably also consider setting up a check so that the user entered version is an actual version and LTE the current kibana version. With the current checks, a user could theoretically enter something like 255.34.32 as a version, which is obviously not a real version and it would technically 'pass' and allow them to submit. @nchaulet please advise if this should be added to this PR or as another issue! |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
|
@Supplementing upgrading agent are not necessarily related to stack version and we could upgrade agent to a version higher than Kibana or a build version, so I am not sure we want to validate too much here, I think testing semver is valid is probably good enough and in line with the server side validation we already added |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 19, 2024
## Summary Closes elastic#197399 Implemented a fix when trying to bulk upgrade agents that are on the current version (see issue for further explanation). Instead of a combobox, a text field would be shown but the current version (in line with the kibana version) wasn't automatically being added to the field as intended due to the wrong variable being passed as the `value` prop. However the correct version was being applied to the behind-the-scenes check, allowing the user to submit even though it looked like nothing had been entered in the field. - Fixed `value` prop on input to use the correct pre-filled value initially - Added a check so that if there were errors with the version being typed in, the button would also get disabled to stop submissions with invalid versions ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks n/a (cherry picked from commit 37df206)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 19, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Agent upgrade form validation fix (#204846)](#204846) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mason Herron","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T19:49:36Z","message":"[Fleet] Agent upgrade form validation fix (#204846)\n\n## Summary\r\n\r\nCloses #197399 \r\n\r\nImplemented a fix when trying to bulk upgrade agents that are on the\r\ncurrent version (see issue for further explanation). Instead of a\r\ncombobox, a text field would be shown but the current version (in line\r\nwith the kibana version) wasn't automatically being added to the field\r\nas intended due to the wrong variable being passed as the `value` prop.\r\nHowever the correct version was being applied to the behind-the-scenes\r\ncheck, allowing the user to submit even though it looked like nothing\r\nhad been entered in the field.\r\n\r\n- Fixed `value` prop on input to use the correct pre-filled value\r\ninitially\r\n- Added a check so that if there were errors with the version being\r\ntyped in, the button would also get disabled to stop submissions with\r\ninvalid versions\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Identify risks\r\n\r\nn/a","sha":"37df2060958a2835875e96db064bb0ed212b7677","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet] Agent upgrade form validation fix","number":204846,"url":"https://github.com/elastic/kibana/pull/204846","mergeCommit":{"message":"[Fleet] Agent upgrade form validation fix (#204846)\n\n## Summary\r\n\r\nCloses #197399 \r\n\r\nImplemented a fix when trying to bulk upgrade agents that are on the\r\ncurrent version (see issue for further explanation). Instead of a\r\ncombobox, a text field would be shown but the current version (in line\r\nwith the kibana version) wasn't automatically being added to the field\r\nas intended due to the wrong variable being passed as the `value` prop.\r\nHowever the correct version was being applied to the behind-the-scenes\r\ncheck, allowing the user to submit even though it looked like nothing\r\nhad been entered in the field.\r\n\r\n- Fixed `value` prop on input to use the correct pre-filled value\r\ninitially\r\n- Added a check so that if there were errors with the version being\r\ntyped in, the button would also get disabled to stop submissions with\r\ninvalid versions\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Identify risks\r\n\r\nn/a","sha":"37df2060958a2835875e96db064bb0ed212b7677"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204846","number":204846,"mergeCommit":{"message":"[Fleet] Agent upgrade form validation fix (#204846)\n\n## Summary\r\n\r\nCloses #197399 \r\n\r\nImplemented a fix when trying to bulk upgrade agents that are on the\r\ncurrent version (see issue for further explanation). Instead of a\r\ncombobox, a text field would be shown but the current version (in line\r\nwith the kibana version) wasn't automatically being added to the field\r\nas intended due to the wrong variable being passed as the `value` prop.\r\nHowever the correct version was being applied to the behind-the-scenes\r\ncheck, allowing the user to submit even though it looked like nothing\r\nhad been entered in the field.\r\n\r\n- Fixed `value` prop on input to use the correct pre-filled value\r\ninitially\r\n- Added a check so that if there were errors with the version being\r\ntyped in, the button would also get disabled to stop submissions with\r\ninvalid versions\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Identify risks\r\n\r\nn/a","sha":"37df2060958a2835875e96db064bb0ed212b7677"}}]}] BACKPORT--> Co-authored-by: Mason Herron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #197399
Implemented a fix when trying to bulk upgrade agents that are on the current version (see issue for further explanation). Instead of a combobox, a text field would be shown but the current version (in line with the kibana version) wasn't automatically being added to the field as intended due to the wrong variable being passed as the
valueprop. However the correct version was being applied to the behind-the-scenes check, allowing the user to submit even though it looked like nothing had been entered in the field.valueprop on input to use the correct pre-filled value initiallyChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
n/a