Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17] Align native box connector configs (#203241) #204836

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.17:

Questions ?

Please refer to the Backport tool documentation

## Summary

Raised in [this community slack
post](https://elasticstack.slack.com/archives/C06U8G8NJBY/p1733445905372799?thread_ts=1733378189.186729&cid=C06U8G8NJBY),
the Native Connector definition from Kibana was using some config fields
(`app_key`, `app_secret`) that didn't align with what the connector
itself expects (`client_id`, `client_secret`). There were also a number
of configurations defined here that are not used by the Box connector
(`use_document_level_security`, `include_inherited_users_and_groups`,
`use_text_extraction_service`, `retry_count`, `path`)

This change moves to align this definition with the source of truth in
the connectors codebase:
https://github.com/elastic/connectors/blob/38c2fdbfe71330d6e95de33a30bf114c29ae4cae/connectors/sources/box.py#L263-L311

T

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

(cherry picked from commit db56f01)
@kibanamachine kibanamachine merged commit adff2bb into elastic:8.17 Dec 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants