Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Discover] Rename Saved Search to Discover Session (#202217) #204818

Merged
merged 2 commits into from
Dec 19, 2024
Merged

[8.x] [Discover] Rename Saved Search to Discover Session (#202217) #204818

merged 2 commits into from
Dec 19, 2024

Conversation

jughosta
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@jughosta
[Discover] Rename Saved Search to Discover Session (elastic#202217)
195dd13 
- Closes elastic#174144

## Summary

This PR renames Saved Search into Discover Session in UI.

- [x] Discover
- [x] Saved Objects page and modal
- [x] Docs
- [x] Other occurrences

<img width="810" alt="Screenshot 2024-12-16 at 15 20 10"
src="https://github.com/user-attachments/assets/e39083da-f496-4ed5-bbdc-8e184897fc41"
/>
<img width="1220" alt="Screenshot 2024-12-11 at 14 40 15"
src="https://github.com/user-attachments/assets/a6dc3e29-e1a5-4304-8148-0108231cc9de"
/>
<img width="1476" alt="Screenshot 2024-12-16 at 14 57 39"
src="https://github.com/user-attachments/assets/4b34c70e-e21a-4d82-85f2-f5a3cb7a3826"
/>

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: wajihaparvez <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
Co-authored-by: Julia Bardi <[email protected]>
(cherry picked from commit 40c9055)

# Conflicts:
#	x-pack/platform/plugins/private/translations/translations/zh-CN.json
@jughosta jughosta enabled auto-merge (squash) December 18, 2024 17:52
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 18, 2024
@jughosta jughosta mentioned this pull request Dec 18, 2024
Merged
8 tasks
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@github-actions GitHub Actions
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@jughosta jughosta added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Fleet Team label for Observability Data Collection Fleet team ci:project-deploy-observability Create an Observability project labels Dec 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta jughosta disabled auto-merge December 18, 2024 17:53
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Fleet Team label for Observability Data Collection Fleet team labels Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@jughosta jughosta removed Team:Fleet Team label for Observability Data Collection Fleet team ci:project-deploy-observability Create an Observability project labels Dec 19, 2024
@jughosta jughosta enabled auto-merge (squash) December 19, 2024 09:14
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
savedSearch 60 61 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 621.6KB 621.7KB +16.0B
canvas 1.1MB 1.1MB +20.0B
cloudSecurityPosture 502.9KB 502.9KB +28.0B
dataViewManagement 140.0KB 140.0KB +4.0B
dataVisualizer 614.8KB 614.8KB +4.0B
discover 813.8KB 813.9KB +49.0B
esqlDataGrid 153.8KB 153.8KB +28.0B
infra 1.7MB 1.7MB +6.0B
ml 4.7MB 4.7MB +182.0B
savedObjectsManagement 86.9KB 87.0KB +4.0B
securitySolution 18.5MB 18.5MB +154.0B
slo 843.1KB 843.2KB +28.0B
spaces 256.7KB 256.7KB +5.0B
transform 475.5KB 475.6KB +47.0B
visDefaultEditor 95.2KB 95.3KB +20.0B
visualizations 321.9KB 321.9KB +16.0B
total +611.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 52.3KB 52.3KB -8.0B
fleet 173.2KB 173.2KB +3.0B
infra 56.0KB 56.0KB +10.0B
savedSearch 11.4KB 11.6KB +130.0B
total +135.0B
Unknown metric groups

API count

id before after diff
savedSearch 61 62 +1

History

@jughosta jughosta requested a review from kertal December 19, 2024 10:23
kertal
kertal approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Fleet Team label for Observability Data Collection Fleet team labels Dec 19, 2024
@jughosta jughosta merged commit db1c118 into elastic:8.x Dec 19, 2024
12 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kertal
Copy link
Member

kertal commented Dec 19, 2024

good to me

@jughosta jughosta deleted the backport/8.x/pr-202217 branch December 19, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport ci:project-deploy-observability Create an Observability project Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jughosta @elasticmachine @kertal