You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean-up all "Asset Inventory" plugin code from the 8.x branch.
Motivation
It was decided in the weekly meetings not to backport any work related to Asset Inventory because it's a new feature. However, this decision was made after I had already shipped the first PR that introduced all the minimal required boilerplate:
Please do not merge this pull request. We disabled auto-merge because we are trying to merge a big PR as part of sustainable architecture migration which is impossible with ever increasing stream of backports. We will resume the automerge after our PR is merged. Reach out to #sustainable-kibana-architecture for more info.
Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clean-up all "Asset Inventory" plugin code from the
8.x
branch.Motivation
It was decided in the weekly meetings not to backport any work related to Asset Inventory because it's a new feature. However, this decision was made after I had already shipped the first PR that introduced all the minimal required boilerplate:
which was backported with:
I couldn't auto revert the merge commit because of this refactor PR that was merged in between:
@elastic/kibana-cloud-security-posture
#202862So I'm deleting and reverting each change manually.
Checklist
release_note:*
label is applied per the guidelinesRisks
No risk at all.