Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Revert backported AssetInventory plugin (revert #202827) #204641

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

albertoblaz
Copy link
Contributor

Summary

Clean-up all "Asset Inventory" plugin code from the 8.x branch.

Motivation

It was decided in the weekly meetings not to backport any work related to Asset Inventory because it's a new feature. However, this decision was made after I had already shipped the first PR that introduced all the minimal required boilerplate:

which was backported with:

I couldn't auto revert the merge commit because of this refactor PR that was merged in between:

So I'm deleting and reverting each change manually.

Checklist

  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Risks

No risk at all.

@albertoblaz albertoblaz added backport release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related labels Dec 17, 2024
@albertoblaz albertoblaz self-assigned this Dec 17, 2024
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@albertoblaz albertoblaz marked this pull request as ready for review December 17, 2024 18:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kapral18
Copy link
Contributor

Please do not merge this pull request. We disabled auto-merge because we are trying to merge a big PR as part of sustainable architecture migration which is impossible with ever increasing stream of backports. We will resume the automerge after our PR is merged. Reach out to #sustainable-kibana-architecture for more info.

@kapral18
Copy link
Contributor

Auto-merge has been re-enabled. Thank you for your patience. :heart

@kapral18 kapral18 enabled auto-merge (squash) December 17, 2024 19:34
@albertoblaz albertoblaz force-pushed the revert-backport/8.x/pr-202291 branch from 67bdd64 to 0e5bfae Compare December 18, 2024 15:03
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #32 / Cloud Security Posture Findings Page onboarding Vulnerabilities - clicking on the No integrations installed prompt action button - install CNVM: navigates to the CNVM integration installation page

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
assetInventory 16 - -16

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
assetInventory 6 - -6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
assetInventory 1.2KB - -1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
assetInventory 3.1KB - -3.1KB
Unknown metric groups

API count

id before after diff
assetInventory 6 - -6

async chunk count

id before after diff
assetInventory 1 - -1

ESLint disabled line counts

id before after diff
assetInventory 5 - -5

References to deprecated APIs

id before after diff
assetInventory 1 - -1

Total ESLint disabled count

id before after diff
assetInventory 5 - -5

History

cc @albertoblaz

@kapral18 kapral18 merged commit dee44c3 into elastic:8.x Dec 18, 2024
8 checks passed
@albertoblaz albertoblaz deleted the revert-backport/8.x/pr-202291 branch December 18, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants