Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Logs UX] Classify logs-data-access and logs-shared as platform plugins (#201263) #204546

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[8.x] [Logs UX] Classify logs-data-access and logs-shared as platform plugins (#201263) #204546

merged 1 commit into from
Dec 17, 2024
+233 −133

Conversation

weltenwort
Copy link
Member

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@weltenwort
[Logs UX] Classify logs-data-access and logs-shared as platform plugi…
a9c510f 
…ns (elastic#201263)

This classifies `@kbn/logs-data-access-plugin`,
`@kbn/logs-shared-plugin` and `@kbn/observability-logs-overview` as
"platform/shared".

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit d5e0d3a)

# Conflicts:
#	.eslintrc.js
@weltenwort weltenwort enabled auto-merge (squash) December 17, 2024 11:11
@weltenwort weltenwort mentioned this pull request Dec 17, 2024
Merged
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

tonyghiani
tonyghiani approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review only

@elasticmachine
Copy link
Contributor

⏳ Build in-progress

  • Buildkite Build
  • Commit: a9c510f
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-204546-a9c510f9f0b0

@weltenwort weltenwort merged commit 7193428 into elastic:8.x Dec 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyghiani tonyghiani tonyghiani approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weltenwort @elasticmachine @tonyghiani