-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Kibana task to deploy agentless connectors for 9.0 #203973
Changes from all commits
4927e05
5716a4e
45278cb
1aedf35
e791be2
8c27d06
8f996be
65a50eb
3c294fe
3ec5dce
6d3fea6
8b19c58
ec75692
4c3eda4
9738e86
cd17d94
294f411
8351e8a
6367d72
bec29db
6d02c2a
39c1429
ee087ba
c59f0cb
e6e96b8
f53d034
898020b
0d83497
b96ec2e
0f4db80
75b22f7
89b18b8
3ec5393
189ee5b
9717116
543af73
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -196,7 +196,7 @@ export const bulkGetAgentPoliciesHandler: FleetRequestHandler< | |
'full query parameter require agent policies read permissions' | ||
); | ||
} | ||
let items = await agentPolicyService.getByIDs(soClient, ids, { | ||
let items = await agentPolicyService.getByIds(soClient, ids, { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Side-effect of removing the usage of AgentPolicyServiceInterface: interface had |
||
withPackagePolicies, | ||
ignoreMissing, | ||
}); | ||
|
@@ -687,7 +687,7 @@ export const GetListAgentPolicyOutputsHandler: FleetRequestHandler< | |
body: { items: [] }, | ||
}); | ||
} | ||
const agentPolicies = await agentPolicyService.getByIDs(soClient, ids, { | ||
const agentPolicies = await agentPolicyService.getByIds(soClient, ids, { | ||
withPackagePolicies: true, | ||
}); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done due to the fact that I needed a
create
method that depends on a lot of other private/internal methods.I had to either make the methods public + add here; or I could pass the service itself. Potentially there might be other way, but I'm not familiar enough with Kibana development yet to know, please tell me if there's a better way :)