Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Clean up e2e test helpers !! #203812

Merged
merged 5 commits into from
Dec 12, 2024
Merged

[Synthetics] Clean up e2e test helpers !! #203812

merged 5 commits into from
Dec 12, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Dec 11, 2024 •
edited by kibanamachine
Loading

Summary

Clean up e2e test helpers

@shahzad31 shahzad31 marked this pull request as ready for review December 11, 2024 16:57
@shahzad31 shahzad31 requested review from a team as code owners December 11, 2024 16:57
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 11, 2024
dominiqueclarke
dominiqueclarke approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Dec 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 removed the request for review from a team December 11, 2024 19:20
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 12, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: d1367a4
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203812-d1367a492e06

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #84 / X-Pack Accessibility Tests - Group 3 Security Solution Accessibility Detections Create Rule Flow Custom Query Rule Define Step preview section meets a11y requirements

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/observability-synthetics-test-data 4 31 +27
@kbn/synthetics-e2e 32 9 -23
total +4

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/observability-synthetics-test-data 0 2 +2
@kbn/synthetics-e2e 2 0 -2
total -0

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/observability-synthetics-test-data 1 2 +1
synthetics 1 0 -1
total -0
Unknown metric groups

API count

id before after diff
@kbn/observability-synthetics-test-data 4 31 +27
@kbn/synthetics-e2e 32 9 -23
total +4

ESLint disabled in files

id before after diff
@kbn/observability-synthetics-test-data 0 1 +1
@kbn/synthetics-e2e 1 0 -1
exploratoryView 2 1 -1
uptime 4 3 -1
ux 3 2 -1
total -3

ESLint disabled line counts

id before after diff
@kbn/observability-synthetics-test-data 0 3 +3
@kbn/synthetics-e2e 17 14 -3
exploratoryView 20 17 -3
uptime 45 42 -3
ux 9 6 -3
total -9

Total ESLint disabled count

id before after diff
@kbn/observability-synthetics-test-data 0 4 +4
@kbn/synthetics-e2e 18 14 -4
exploratoryView 22 18 -4
uptime 49 45 -4
ux 12 8 -4
total -12

History

@shahzad31 shahzad31 merged commit 0203bba into elastic:main Dec 12, 2024
8 checks passed
@shahzad31 shahzad31 deleted the fix-root-path branch December 12, 2024 09:52
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12293894303

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- Sustainable Kibana Architecture: Change visibility to "shared" (#203842)
- [Lens] Fix styling popover controls (#202865)
- [eem] _search fixes + integration tests (#203403)
- [React18] Migrate test suites to account for testing library upgrades security-generative-ai (#201160)

Manual backport

To create the backport manually run:

node scripts/backport --pr 203812

Questions ?

Please refer to the Backport tool documentation

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Dec 12, 2024
@shahzad31
[Synthetics] Clean up e2e test helpers !! (elastic#203812)
af90044 
## Summary

Clean up e2e test helpers

(cherry picked from commit 0203bba)

# Conflicts:
#	x-pack/plugins/observability_solution/uptime/e2e/tasks/read_kibana_config.ts
@shahzad31 shahzad31 mentioned this pull request Dec 12, 2024
Merged
@shahzad31
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@shahzad31 @CAWilson94
[Synthetics] Clean up e2e test helpers !! (elastic#203812)
5633b40 
## Summary

Clean up e2e test helpers
shahzad31 added a commit that referenced this pull request Dec 12, 2024
@shahzad31 @kibanamachine
[8.x] [Synthetics] Clean up e2e test helpers !! (#203812) (#203999)
ac450e9 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] Clean up e2e test helpers !!
(#203812)](#203812)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-12T09:52:19Z","message":"[Synthetics]
Clean up e2e test helpers !! (#203812)\n\n## Summary\r\n\r\nClean up e2e
test
helpers","sha":"0203bba44f9dcac037f23a23e4945298ef6b5912","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management"],"number":203812,"url":"https://github.com/elastic/kibana/pull/203812","mergeCommit":{"message":"[Synthetics]
Clean up e2e test helpers !! (#203812)\n\n## Summary\r\n\r\nClean up e2e
test
helpers","sha":"0203bba44f9dcac037f23a23e4945298ef6b5912"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203812","number":203812,"mergeCommit":{"message":"[Synthetics]
Clean up e2e test helpers !! (#203812)\n\n## Summary\r\n\r\nClean up e2e
test helpers","sha":"0203bba44f9dcac037f23a23e4945298ef6b5912"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@shahzad31 @CAWilson94
[Synthetics] Clean up e2e test helpers !! (elastic#203812)
2c799fd 
## Summary

Clean up e2e test helpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahzad31 @elasticmachine @kibanamachine @dominiqueclarke