Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17] Fix issue with short URL not working for dashboard (#197484) #203737

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.17:

Questions ?

Please refer to the Backport tool documentation

\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n","sha":"4511abe03e7d4dfbe539f8707f9a42410d600df1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","ui-copy","backport:prev-major"],"title":"Fix issue with short URL not working for dashboard","number":197484,"url":"https://github.com//pull/197484","mergeCommit":{"message":"Fix issue with short URL not working for dashboard (#197484)\n\n## Summary\r\n\r\n\r\nThis PR Resolves https://github.com//issues/191090\r\n\r\nIn addition, it adds implementation to allow consumers pass in their\r\ncallout message of choice for handling the message displayed to users on\r\nattempting to copy a url especially that when short urls are allowed, in\r\ndraft mode the URL copied will not point to the same configuration once\r\nthe change has been persisted.\r\n\r\nFor lens the message that was displayed previously when presented with\r\nthe option to copy a link remains the same, however for dashboard a new\r\nmessage is being added. See screenshot below;\r\n\r\n\r\n

\"Screenshot

\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n","sha":"4511abe03e7d4dfbe539f8707f9a42410d600df1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/197484","number":197484,"mergeCommit":{"message":"Fix issue with short URL not working for dashboard (#197484)\n\n## Summary\r\n\r\n\r\nThis PR Resolves https://github.com//issues/191090\r\n\r\nIn addition, it adds implementation to allow consumers pass in their\r\ncallout message of choice for handling the message displayed to users on\r\nattempting to copy a url especially that when short urls are allowed, in\r\ndraft mode the URL copied will not point to the same configuration once\r\nthe change has been persisted.\r\n\r\nFor lens the message that was displayed previously when presented with\r\nthe option to copy a link remains the same, however for dashboard a new\r\nmessage is being added. See screenshot below;\r\n\r\n\r\n

\"Screenshot

\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n","sha":"4511abe03e7d4dfbe539f8707f9a42410d600df1"}}]}] BACKPORT-->

## Summary

This PR  Resolves elastic#191090

In addition, it adds implementation to allow consumers pass in their
callout message of choice for handling the message displayed to users on
attempting to copy a url especially that when short urls are allowed, in
draft mode the URL copied will not point to the same configuration once
the change has been persisted.

For lens the message that was displayed previously when presented with
the option to copy a link remains the same, however for dashboard a new
message is being added. See screenshot below;

<img width="540" alt="Screenshot 2024-10-23 at 22 58 46"
src="https://github.com/user-attachments/assets/90d584b5-d48c-4521-b75c-2c7827ddf444">

### Checklist
<!--
Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials -->
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
<!--
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

-->

(cherry picked from commit 4511abe)
@kibanamachine kibanamachine merged commit 5c48d5d into elastic:8.17 Dec 11, 2024
11 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 647.5KB 649.8KB +2.3KB
lens 1.5MB 1.5MB +481.0B
total +2.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
share 15 16 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
share 57.9KB 57.9KB +10.0B

cc @eokoneyo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants